-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: delete Project fail #3981
Fix: delete Project fail #3981
Conversation
Signed-off-by: StevenLeiZhang <zhangleiic@163.com>
Codecov Report
@@ Coverage Diff @@
## master #3981 +/- ##
==========================================
- Coverage 60.54% 60.33% -0.21%
==========================================
Files 324 324
Lines 31085 31087 +2
==========================================
- Hits 18820 18756 -64
- Misses 9805 9859 +54
- Partials 2460 2472 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Successfully created backport PR #3996 for |
Signed-off-by: StevenLeiZhang zhangleiic@163.com
Description of your changes
Fixes #3980
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer