Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: delete Project fail #3981

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

StevenLeiZhang
Copy link
Collaborator

Signed-off-by: StevenLeiZhang zhangleiic@163.com

Description of your changes

Fixes #3980

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: StevenLeiZhang <zhangleiic@163.com>
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #3981 (87347f1) into master (1d82378) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3981      +/-   ##
==========================================
- Coverage   60.54%   60.33%   -0.21%     
==========================================
  Files         324      324              
  Lines       31085    31087       +2     
==========================================
- Hits        18820    18756      -64     
- Misses       9805     9859      +54     
- Partials     2460     2472      +12     
Flag Coverage Δ
apiserver-unittests 35.03% <100.00%> (-0.04%) ⬇️
core-unittests 54.09% <ø> (-0.17%) ⬇️
e2e-multicluster-test 26.98% <ø> (-0.21%) ⬇️
e2e-rollout-tests 22.63% <ø> (+<0.01%) ⬆️
e2etests 29.81% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/service/config.go 68.96% <100.00%> (+0.26%) ⬆️
pkg/addon/registry.go 37.34% <0.00%> (-15.67%) ⬇️
pkg/apiserver/event/sync/convert/convert.go 49.36% <0.00%> (-11.40%) ⬇️
pkg/resourcekeeper/dispatch.go 75.51% <0.00%> (-8.17%) ⬇️
...es/policydefinition/policydefinition_controller.go 69.47% <0.00%> (-7.37%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-7.37%) ⬇️
...ev/v1alpha2/core/scopes/healthscope/healthscope.go 66.16% <0.00%> (-3.39%) ⬇️
pkg/cue/definition/template.go 63.52% <0.00%> (-2.05%) ⬇️
pkg/controller/utils/capability.go 79.42% <0.00%> (-1.77%) ⬇️
...dev/v1alpha2/application/application_controller.go 83.63% <0.00%> (-1.22%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d82378...87347f1. Read the comment docs.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@wonderflow wonderflow added the backport release-1.4 add this label will automatically backport this PR to release-1.4 branch label May 25, 2022
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow merged commit dc8f558 into kubevela:master May 26, 2022
@github-actions
Copy link

Successfully created backport PR #3996 for release-1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.4 add this label will automatically backport this PR to release-1.4 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete Project fail on VelaUX
3 participants