Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: render color for outputs of vela up command #4133

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

JarHMJ
Copy link
Member

@JarHMJ JarHMJ commented Jun 8, 2022

Signed-off-by: huangminjie minjie.huang@daocloud.io

render color for outputs of vela up command (#3903 )

Description of your changes

Fixes #3903

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@JarHMJ
Copy link
Member Author

JarHMJ commented Jun 8, 2022

image

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #4133 (566486f) into master (deaf309) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4133      +/-   ##
==========================================
- Coverage   60.21%   60.20%   -0.02%     
==========================================
  Files         330      330              
  Lines       31789    31789              
==========================================
- Hits        19141    19137       -4     
- Misses      10140    10143       +3     
- Partials     2508     2509       +1     
Flag Coverage Δ
apiserver-unittests 35.40% <ø> (+0.03%) ⬆️
core-unittests 54.70% <ø> (-0.02%) ⬇️
e2e-multicluster-test 20.05% <ø> (-0.09%) ⬇️
e2e-rollout-tests 22.40% <ø> (+0.05%) ⬆️
e2etests 29.15% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/resourcekeeper/componentrevision.go 64.28% <0.00%> (-7.15%) ⬇️
.../manualscalertrait/manualscalertrait_controller.go 67.30% <0.00%> (-5.77%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 63.82% <0.00%> (-5.32%) ⬇️
...es/policydefinition/policydefinition_controller.go 64.21% <0.00%> (-5.27%) ⬇️
pkg/workflow/recorder/recorder.go 85.48% <0.00%> (-1.62%) ⬇️
...dev/v1alpha2/application/application_controller.go 83.63% <0.00%> (-1.22%) ⬇️
pkg/apiserver/domain/service/addon.go 58.69% <0.00%> (-0.73%) ⬇️
pkg/workflow/workflow.go 81.68% <0.00%> (-0.25%) ⬇️
pkg/controller/utils/capability.go 81.19% <0.00%> (+0.88%) ⬆️
pkg/addon/utils.go 70.87% <0.00%> (+0.97%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deaf309...566486f. Read the comment docs.

@wonderflow
Copy link
Collaborator

image

I hope these commands can have color

@JarHMJ
Copy link
Member Author

JarHMJ commented Jun 8, 2022

image

Is this style OK?

@wonderflow
Copy link
Collaborator

For the last line, i hope only application name has color

Signed-off-by: huangminjie <minjie.huang@daocloud.io>
@JarHMJ
Copy link
Member Author

JarHMJ commented Jun 8, 2022

For the last line, i hope only application name has color

image

Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool enhancement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] render color for outputs of vela up command
4 participants