Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: command vela def apply support directory #4142

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

ivyilike
Copy link
Contributor

@ivyilike ivyilike commented Jun 9, 2022

Signed-off-by: ivyilike pww123@cmbchina.com

Description of your changes

Fixes #4022

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@fourierr
Copy link
Member

fourierr commented Jun 9, 2022

good work

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #4142 (b62ebb0) into master (573f601) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4142      +/-   ##
==========================================
- Coverage   61.37%   61.28%   -0.10%     
==========================================
  Files         348      348              
  Lines       34387    34387              
==========================================
- Hits        21105    21074      -31     
- Misses      10540    10555      +15     
- Partials     2742     2758      +16     
Flag Coverage Δ
apiserver-e2etests 27.66% <ø> (+0.01%) ⬆️
apiserver-unittests 39.89% <ø> (+<0.01%) ⬆️
core-unittests 56.40% <ø> (-0.06%) ⬇️
e2e-multicluster-test 19.75% <ø> (-0.05%) ⬇️
e2e-rollout-tests 22.92% <ø> (+0.07%) ⬆️
e2etests 29.01% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tepdefinition/workflowstepdefinition_controller.go 63.82% <0.00%> (-5.32%) ⬇️
...es/policydefinition/policydefinition_controller.go 64.21% <0.00%> (-5.27%) ⬇️
pkg/workflow/providers/multicluster/deploy.go 77.52% <0.00%> (-2.25%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 86.95% <0.00%> (-2.18%) ⬇️
...kg/workflow/providers/multicluster/multicluster.go 81.25% <0.00%> (-2.09%) ⬇️
pkg/cue/definition/template.go 62.80% <0.00%> (-2.00%) ⬇️
...dev/v1alpha2/application/application_controller.go 85.88% <0.00%> (-1.23%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 72.39% <0.00%> (-0.92%) ⬇️
pkg/multicluster/virtual_cluster.go 91.05% <0.00%> (-0.82%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 65.77% <0.00%> (-0.77%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 573f601...b62ebb0. Read the comment docs.

@oeular
Copy link
Member

oeular commented Jun 9, 2022

good job!

references/cli/def.go Outdated Show resolved Hide resolved
references/cli/def.go Outdated Show resolved Hide resolved
references/cli/def.go Outdated Show resolved Hide resolved
references/cli/def.go Outdated Show resolved Hide resolved
references/cli/def.go Outdated Show resolved Hide resolved
references/cli/def.go Outdated Show resolved Hide resolved
@wonderflow
Copy link
Collaborator

@ivyilike Hi, I'm working on this as v1.5 is going to release, we'll code freeze in 1-2 days.

@wonderflow wonderflow force-pushed the cli_defApplyCommand branch 2 times, most recently from 66b8e41 to 51b06f6 Compare July 24, 2022 04:09
@wonderflow wonderflow force-pushed the cli_defApplyCommand branch 2 times, most recently from 6a49fac to 7b76a8f Compare July 24, 2022 06:47
Co-authored-by: ivyilike <pww123@cmbchina.com>

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@wonderflow wonderflow merged commit 3e57246 into kubevela:master Jul 24, 2022
@wonderflow
Copy link
Collaborator

/backport 1.5

@github-actions github-actions bot added the backport release-1.5 add this label will automatically backport this PR to release-1.5 branch label Jul 24, 2022
@github-actions
Copy link

Successfully created backport PR #4432 for release-1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.5 add this label will automatically backport this PR to release-1.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] the command vela def apply support directory
7 participants