Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix the dash case in if validate for inputs #4253

Merged
merged 1 commit into from Jun 27, 2022

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Jun 24, 2022

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #4253 (99e2827) into master (92fa67c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4253      +/-   ##
==========================================
- Coverage   60.37%   60.34%   -0.03%     
==========================================
  Files         338      338              
  Lines       32909    32909              
==========================================
- Hits        19869    19860       -9     
- Misses      10426    10434       +8     
- Partials     2614     2615       +1     
Flag Coverage Δ
apiserver-unittests 34.51% <0.00%> (+0.01%) ⬆️
core-unittests 55.18% <100.00%> (-0.03%) ⬇️
e2e-multicluster-test 20.44% <0.00%> (-0.06%) ⬇️
e2e-rollout-tests 22.38% <0.00%> (+<0.01%) ⬆️
e2etests 29.20% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/workflow/tasks/custom/task.go 75.76% <100.00%> (+0.68%) ⬆️
...v/v1alpha2/componentdefinition/mutating_handler.go 74.00% <0.00%> (-6.00%) ⬇️
...ponentdefinition/componentdefinition_controller.go 80.00% <0.00%> (-5.56%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 63.82% <0.00%> (-5.32%) ⬇️
...es/policydefinition/policydefinition_controller.go 69.47% <0.00%> (-2.11%) ⬇️
...dev/v1alpha2/application/application_controller.go 84.04% <0.00%> (-1.23%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 72.17% <0.00%> (-0.29%) ⬇️
pkg/controller/utils/capability.go 79.86% <0.00%> (ø)
pkg/apiserver/domain/service/authentication.go 50.18% <0.00%> (+1.11%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92fa67c...99e2827. Read the comment docs.

@Somefive Somefive merged commit 82fc748 into kubevela:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants