Fix: provider can't be added since 1.4 as context abused && Feat: add cache for remote terraform module in vela show #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
added
the
backport release-1.4
wonderflow
requested review from
Somefive,
zzxwill,
StevenLeiZhang,
barnettZQG and
leejanee
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4256 +/- ##
==========================================
+ Coverage 59.87% 60.41% +0.54%
==========================================
Files 338 338
Lines 32909 32908 -1
==========================================
+ Hits 19703 19881 +178
+ Misses 10594 10415 -179
Partials 2612 2612
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
wonderflow
changed the title
wonderflow
force-pushed
the
fixprovider
branch
3 times, most recently
from
a3ccfce
to
b221e09
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
wonderflow
force-pushed
the
fixprovider
branch
2 times, most recently
from
368c931
to
7c45e20
Compare
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
zzxwill
reviewed
Jun 27, 2022
| tmpPath := filepath.Join("./tmp/terraform", name) | ||
| // Check if the directory exists. If yes, remove it. | ||
| if _, err := os.Stat(tmpPath); err == nil { | ||
| err := os.RemoveAll(tmpPath) |
There was a problem hiding this comment.
When will the cache path be cleaned up?
There was a problem hiding this comment.
users manually cleaned that
Somefive
approved these changes
Jun 27, 2022
|
Successfully created backport PR #4263 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com
Description of your changes
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer