Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support stdin and url for vela ql #4274

Merged
merged 1 commit into from Jun 29, 2022

Conversation

wonderflow
Copy link
Collaborator

@wonderflow wonderflow commented Jun 29, 2022

Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com

Description of your changes

It supports this kind of usage:

cat <<EOF | vela ql -f -
import (
        "vela/ql"
)
configmap: ql.#Read & {
        value: {
                kind:       "Secret"
                apiVersion: "v1"
                metadata: {
                        name:      "outputs-ecs"
                        namespace: "default"
                }
        }
}
status: configmap.value.data["this_public_ip"]
EOF

And read from URL.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@wonderflow wonderflow added the backport release-1.4 add this label will automatically backport this PR to release-1.4 branch label Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #4274 (235a447) into master (3709400) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4274      +/-   ##
==========================================
- Coverage   60.61%   60.48%   -0.13%     
==========================================
  Files         341      341              
  Lines       33110    33110              
==========================================
- Hits        20069    20028      -41     
- Misses      10407    10444      +37     
- Partials     2634     2638       +4     
Flag Coverage Δ
apiserver-unittests 33.59% <0.00%> (-0.78%) ⬇️
core-unittests 55.45% <0.00%> (-0.06%) ⬇️
e2e-multicluster-test 20.38% <0.00%> (-0.04%) ⬇️
e2e-rollout-tests 22.35% <ø> (-0.01%) ⬇️
e2etests 29.31% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/velaql/parse.go 65.67% <0.00%> (ø)
pkg/addon/registry.go 37.34% <0.00%> (-15.67%) ⬇️
pkg/workflow/hooks/data_passing.go 29.41% <0.00%> (-11.77%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 63.82% <0.00%> (-7.45%) ⬇️
...es/policydefinition/policydefinition_controller.go 64.21% <0.00%> (-7.37%) ⬇️
pkg/apiserver/interfaces/api/oam_application.go 63.07% <0.00%> (-6.16%) ⬇️
.../manualscalertrait/manualscalertrait_controller.go 67.30% <0.00%> (-5.77%) ⬇️
pkg/apiserver/utils/bcode/bcode.go 50.00% <0.00%> (-2.95%) ⬇️
...dev/v1alpha2/application/application_controller.go 82.82% <0.00%> (-2.46%) ⬇️
pkg/addon/utils.go 72.12% <0.00%> (-0.61%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3709400...235a447. Read the comment docs.

@wonderflow wonderflow merged commit 71df27a into kubevela:master Jun 29, 2022
@wonderflow wonderflow deleted the supportql branch June 29, 2022 06:50
@github-actions
Copy link

Successfully created backport PR #4277 for release-1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.4 add this label will automatically backport this PR to release-1.4 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants