Feat: disable comprev when rollout trait not used #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
requested review from
barnettZQG,
wonderflow and
leejanee
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4281 +/- ##
==========================================
+ Coverage 60.61% 60.68% +0.06%
==========================================
Files 341 341
Lines 33148 33158 +10
==========================================
+ Hits 20092 20121 +29
+ Misses 10417 10401 -16
+ Partials 2639 2636 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Somefive
force-pushed
the
feat/disable-comprev-for-norollout
branch
6 times, most recently
from
8ea9cd1
to
3c9e2ae
Compare
wonderflow
reviewed
Jun 30, 2022
charts/vela-core/README.md
Outdated
| @@ -93,6 +93,7 @@ helm install --create-namespace -n vela-system kubevela kubevela/vela-core --wai | |||
| | `optimize.enableInMemoryWorkflowContext` | Optimize workflow by use in-memory context. | `false` | | |||
| | `optimize.disableResourceApplyDoubleCheck` | Optimize workflow by ignoring resource double check after apply. | `false` | | |||
| | `optimize.enableResourceTrackerDeleteOnlyTrigger` | Optimize resourcetracker by only trigger reconcile when resourcetracker is deleted. | `true` | | |||
| | `featureGates.legacyComponentRevision` | if disabled, only component with rollout trait will create component revisions | `false` | | |||
There was a problem hiding this comment.
it should be true by default
Somefive
force-pushed
the
feat/disable-comprev-for-norollout
branch
from
3c9e2ae
to
86afc61
Compare
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
feat/disable-comprev-for-norollout
branch
from
86afc61
to
36abad4
Compare
wonderflow
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Somefive yd219913@alibaba-inc.com
Description of your changes
When rollout trait is not used in component, the component revision will not be created. (The computation of revision hash and revision name remains.)
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer