Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: addon use cluster sdk to check deploy #4282

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

huiwq1990
Copy link
Contributor

Signed-off-by: huiwq1990 huiwq1990@163.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: huiwq1990 <huiwq1990@163.com>
@huiwq1990 huiwq1990 changed the title addon use cluster sdk to check deploy Feat: addon use cluster sdk to check deploy Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #4282 (e1e81a0) into master (0469ba4) will increase coverage by 0.09%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #4282      +/-   ##
==========================================
+ Coverage   60.61%   60.70%   +0.09%     
==========================================
  Files         341      341              
  Lines       33148    33147       -1     
==========================================
+ Hits        20092    20123      +31     
+ Misses      10417    10395      -22     
+ Partials     2639     2629      -10     
Flag Coverage Δ
apiserver-unittests 34.18% <0.00%> (+0.13%) ⬆️
core-unittests 55.48% <83.33%> (-0.04%) ⬇️
e2e-multicluster-test 20.39% <0.00%> (+0.08%) ⬆️
e2e-rollout-tests 22.35% <ø> (-0.01%) ⬇️
e2etests 29.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/addon.go 66.53% <83.33%> (+0.97%) ⬆️
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-7.37%) ⬇️
.../manualscalertrait/manualscalertrait_controller.go 67.30% <0.00%> (-5.77%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 63.82% <0.00%> (-5.32%) ⬇️
pkg/addon/push.go 75.20% <0.00%> (-1.60%) ⬇️
pkg/addon/registry.go 53.01% <0.00%> (ø)
...es/policydefinition/policydefinition_controller.go 64.21% <0.00%> (ø)
pkg/workflow/workflow.go 84.77% <0.00%> (+0.42%) ⬆️
.../core/scopes/healthscope/healthscope_controller.go 72.46% <0.00%> (+0.57%) ⬆️
pkg/workflow/tasks/custom/task.go 76.57% <0.00%> (+0.69%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0469ba4...e1e81a0. Read the comment docs.

}

clusterNames := sets.String{}
if len(clusters.Items) != 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this if statement required?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this line can be omitted.

@wonderflow
Copy link
Collaborator

Thanks for your contribution

@wonderflow wonderflow merged commit 68d2d84 into kubevela:master Jun 30, 2022
@huiwq1990 huiwq1990 deleted the feat-addoncluster branch July 11, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants