-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: addon use cluster sdk to check deploy #4282
Conversation
Signed-off-by: huiwq1990 <huiwq1990@163.com>
Codecov Report
@@ Coverage Diff @@
## master #4282 +/- ##
==========================================
+ Coverage 60.61% 60.70% +0.09%
==========================================
Files 341 341
Lines 33148 33147 -1
==========================================
+ Hits 20092 20123 +31
+ Misses 10417 10395 -22
+ Partials 2639 2629 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
} | ||
|
||
clusterNames := sets.String{} | ||
if len(clusters.Items) != 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this if
statement required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this line can be omitted.
Thanks for your contribution |
Signed-off-by: huiwq1990 huiwq1990@163.com
Description of your changes
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer