Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: print addon parameters recursively #4290

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

charlie0129
Copy link
Member

Description of your changes

Previously, we can only view the top-level parameters.
Notice the nested objects didn't show up.

Screenshot from 2022-06-30 20-52-05

Now we can show nested parameters no matter how deep they are.
Also with their default/current values.

Screenshot from 2022-06-30 20-57-34

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129 charlie0129 marked this pull request as ready for review June 30, 2022 13:12
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #4290 (fb30bd7) into master (68d2d84) will increase coverage by 12.74%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4290       +/-   ##
===========================================
+ Coverage   47.95%   60.69%   +12.74%     
===========================================
  Files         306      341       +35     
  Lines       28960    33157     +4197     
===========================================
+ Hits        13887    20124     +6237     
+ Misses      13452    10404     -3048     
- Partials     1621     2629     +1008     
Flag Coverage Δ
apiserver-unittests 34.19% <ø> (?)
core-unittests 55.46% <ø> (-0.08%) ⬇️
e2e-multicluster-test 20.37% <ø> (-0.02%) ⬇️
e2e-rollout-tests 22.47% <ø> (ø)
e2etests 28.81% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/registry.go 37.34% <0.00%> (-8.44%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 69.14% <0.00%> (-7.45%) ⬇️
...es/policydefinition/policydefinition_controller.go 64.21% <0.00%> (-5.27%) ⬇️
pkg/controller/utils/capability.go 79.82% <0.00%> (-1.78%) ⬇️
...dev/v1alpha2/application/application_controller.go 85.88% <0.00%> (-1.23%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 87.91% <0.00%> (-1.10%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 72.29% <0.00%> (-0.92%) ⬇️
pkg/cue/definition/template.go 64.80% <0.00%> (-0.80%) ⬇️
pkg/workflow/workflow.go 84.35% <0.00%> (-0.43%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 64.25% <0.00%> (ø)
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d2d84...fb30bd7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants