Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix the goroutine leak in CUE when use http request #4298

Merged
merged 1 commit into from Jul 1, 2022

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Jul 1, 2022

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

Fixes #4294

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@wonderflow

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong added backport release-1.2 add this label will automatically backport this PR to release-1.2 branch backport release-1.3 add this label will automatically backport this PR to release-1.3 branch backport release-1.4 add this label will automatically backport this PR to release-1.4 branch labels Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #4298 (559ef83) into master (51a6059) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4298      +/-   ##
==========================================
- Coverage   60.74%   60.71%   -0.04%     
==========================================
  Files         341      341              
  Lines       33163    33163              
==========================================
- Hits        20144    20134      -10     
- Misses      10393    10400       +7     
- Partials     2626     2629       +3     
Flag Coverage Δ
apiserver-unittests 34.10% <0.00%> (-0.06%) ⬇️
core-unittests 55.51% <100.00%> (-0.01%) ⬇️
e2e-multicluster-test 20.36% <0.00%> (-0.04%) ⬇️
e2e-rollout-tests 22.41% <0.00%> (+0.05%) ⬆️
e2etests 28.93% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/builtin/http/http.go 65.82% <100.00%> (ø)
pkg/addon/registry.go 37.34% <0.00%> (-15.67%) ⬇️
...kg/apiserver/infrastructure/datastore/datastore.go 66.66% <0.00%> (-11.12%) ⬇️
pkg/resourcekeeper/dispatch.go 76.92% <0.00%> (-7.70%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 40.29% <0.00%> (-4.48%) ⬇️
pkg/apiserver/event/sync/worker.go 71.73% <0.00%> (-4.35%) ⬇️
pkg/apiserver/event/sync/store.go 62.00% <0.00%> (-3.00%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 70.52% <0.00%> (-2.11%) ⬇️
pkg/apiserver/domain/service/authentication.go 49.07% <0.00%> (-1.12%) ⬇️
...dev/v1alpha2/application/application_controller.go 84.66% <0.00%> (-0.93%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a6059...559ef83. Read the comment docs.

@wonderflow wonderflow changed the title Fix: fix the goroutine leak in http request Fix: fix the goroutine leak in CUE when use http request Jul 1, 2022
@wonderflow wonderflow merged commit c6d170f into kubevela:master Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Successfully created backport PR #4302 for release-1.2.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Successfully created backport PR #4303 for release-1.3.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Successfully created backport PR #4304 for release-1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.2 add this label will automatically backport this PR to release-1.2 branch backport release-1.3 add this label will automatically backport this PR to release-1.3 branch backport release-1.4 add this label will automatically backport this PR to release-1.4 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goroutines leak if the server don't close the connections
2 participants