Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fail to query the application logs with the special characters #4305

Merged
merged 1 commit into from Jul 1, 2022

Conversation

barnettZQG
Copy link
Collaborator

Signed-off-by: barnettZQG barnett.zqg@gmail.com

Description of your changes

Fixes #4118

Current, like this:
image

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@barnettZQG barnettZQG added the backport release-1.4 add this label will automatically backport this PR to release-1.4 branch label Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #4305 (0101396) into master (b2dfee1) will decrease coverage by 0.10%.
The diff coverage is 62.85%.

@@            Coverage Diff             @@
##           master    #4305      +/-   ##
==========================================
- Coverage   60.62%   60.52%   -0.11%     
==========================================
  Files         341      341              
  Lines       33157    33178      +21     
==========================================
- Hits        20102    20081      -21     
- Misses      10419    10475      +56     
+ Partials     2636     2622      -14     
Flag Coverage Δ
apiserver-unittests 34.04% <62.85%> (-0.04%) ⬇️
core-unittests 55.53% <56.25%> (+0.04%) ⬆️
e2e-multicluster-test 20.39% <0.00%> (+0.05%) ⬆️
e2e-rollout-tests 22.41% <0.00%> (+<0.01%) ⬆️
e2etests 28.52% <0.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/velaql/providers/query/handler.go 34.11% <59.37%> (+0.46%) ⬆️
pkg/apiserver/domain/service/velaql.go 60.00% <100.00%> (+5.45%) ⬆️
pkg/addon/registry.go 37.34% <0.00%> (-15.67%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 57.68% <0.00%> (-14.79%) ⬇️
pkg/apiserver/event/sync/workflow_record.go 50.00% <0.00%> (-10.00%) ⬇️
pkg/addon/helper.go 67.70% <0.00%> (-1.57%) ⬇️
pkg/addon/versioned_registry.go 72.50% <0.00%> (-0.68%) ⬇️
...dev/v1alpha2/application/application_controller.go 83.74% <0.00%> (-0.62%) ⬇️
pkg/controller/utils/capability.go 80.70% <0.00%> (-0.45%) ⬇️
pkg/workflow/workflow.go 84.14% <0.00%> (-0.22%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2dfee1...0101396. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Successfully created backport PR #4308 for release-1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.4 add this label will automatically backport this PR to release-1.4 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to query the application logs if the log with the special characters
5 participants