Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: show or list revisions in vela def get and vela show #4307

Merged
merged 7 commits into from Jul 6, 2022

Conversation

charlie0129
Copy link
Member

Description of your changes

List revisions in vela def get

$ vela def get webservice --revisions
NAME      	REVISION	TYPE     	HASH            
webservice	1       	Component	dfa072dac5088ed8
webservice	2       	Component	c0a0c0591d0bc6

Get a particular revision in vela def get

$ vela def get webservice --revision 2 | head -n3 # or `--revision v2`, `-r2`
import (
	"strconv"
)
# ... omitted

Get a particular revision in vela show

$ vela show webservice --revision 2 | head -n1 # or `--revision v1`, `-r2`
# Properties
# ... omitted

Fixes #4131

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #4307 (debe52d) into master (ffb0d2f) will decrease coverage by 1.77%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #4307      +/-   ##
==========================================
- Coverage   60.37%   58.59%   -1.78%     
==========================================
  Files         341      336       -5     
  Lines       33110    33089      -21     
==========================================
- Hits        19989    19389     -600     
- Misses      10490    11141     +651     
+ Partials     2631     2559      -72     
Flag Coverage Δ
apiserver-unittests 34.03% <0.00%> (+0.42%) ⬆️
core-unittests 55.48% <83.33%> (+0.07%) ⬆️
e2e-multicluster-test ?
e2e-rollout-tests 22.47% <ø> (+0.13%) ⬆️
e2etests 29.00% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/definition/definition.go 75.82% <83.33%> (+1.41%) ⬆️
pkg/controller/utils/actions.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/resourcekeeper/containsresources.go 0.00% <0.00%> (-71.43%) ⬇️
pkg/auth/identity.go 6.12% <0.00%> (-69.39%) ⬇️
pkg/client/delegating_handler_client.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/auth/kubeconfig.go 0.00% <0.00%> (-65.31%) ⬇️
pkg/utils/json.go 0.00% <0.00%> (-60.00%) ⬇️
pkg/resourcetracker/tree.go 17.89% <0.00%> (-57.37%) ⬇️
pkg/policy/envbinding/placement.go 35.00% <0.00%> (-55.00%) ⬇️
pkg/oam/auxiliary.go 30.00% <0.00%> (-53.34%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb0d2f...debe52d. Read the comment docs.

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] vela def support list version and get detail for definition revision
3 participants