Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refine the output of velaux addon #4332

Merged
merged 1 commit into from Jul 6, 2022

Conversation

wonderflow
Copy link
Collaborator

Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com

Description of your changes

fixes #3902

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #4332 (b957ca8) into master (a3ab087) will increase coverage by 1.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4332      +/-   ##
==========================================
+ Coverage   59.13%   60.63%   +1.49%     
==========================================
  Files         343      343              
  Lines       33722    33722              
==========================================
+ Hits        19942    20447     +505     
+ Misses      11106    10599     -507     
- Partials     2674     2676       +2     
Flag Coverage Δ
apiserver-unittests 34.45% <ø> (-0.06%) ⬇️
core-unittests 55.26% <ø> (-0.06%) ⬇️
e2e-multicluster-test 20.04% <ø> (-0.04%) ⬇️
e2e-rollout-tests 22.30% <ø> (+0.01%) ⬆️
e2etests 28.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/registry.go 37.34% <0.00%> (-15.67%) ⬇️
pkg/addon/cache.go 53.75% <0.00%> (-8.75%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 40.29% <0.00%> (-5.98%) ⬇️
pkg/apiserver/event/sync/store.go 65.25% <0.00%> (-4.24%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 63.49% <0.00%> (-1.15%) ⬇️
pkg/apiserver/domain/service/application.go 57.18% <0.00%> (-0.20%) ⬇️
pkg/addon/versioned_registry.go 74.16% <0.00%> (ø)
pkg/apiserver/event/sync/worker.go 77.08% <0.00%> (ø)
...tepdefinition/workflowstepdefinition_controller.go 71.27% <0.00%> (ø)
pkg/addon/utils.go 73.14% <0.00%> (+0.57%) ⬆️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ab087...b957ca8. Read the comment docs.

@Somefive Somefive merged commit e0ab168 into kubevela:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] refine the output of velaux addon installation
2 participants