Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: supports multiple difference compare modes #4334

Merged
merged 2 commits into from Jul 8, 2022

Conversation

barnettZQG
Copy link
Collaborator

@barnettZQG barnettZQG commented Jul 6, 2022

Signed-off-by: barnettZQG barnett.zqg@gmail.com

Description of your changes

refer to kubevela/velaux#572

Fixes: #4233

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

@barnettZQG barnettZQG changed the title Feat: supports multiple differential alignment modes Feat: supports multiple difference alignment modes Jul 6, 2022
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #4334 (b91fbfe) into master (09acc8a) will increase coverage by 0.07%.
The diff coverage is 63.84%.

@@            Coverage Diff             @@
##           master    #4334      +/-   ##
==========================================
+ Coverage   60.61%   60.69%   +0.07%     
==========================================
  Files         343      343              
  Lines       33745    33886     +141     
==========================================
+ Hits        20456    20567     +111     
- Misses      10609    10629      +20     
- Partials     2680     2690      +10     
Flag Coverage Δ
apiserver-unittests 34.54% <63.84%> (+0.04%) ⬆️
core-unittests 55.41% <ø> (+0.15%) ⬆️
e2e-multicluster-test 19.98% <0.00%> (-0.12%) ⬇️
e2e-rollout-tests 22.33% <ø> (+0.01%) ⬆️
e2etests 28.67% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/repository/application.go 42.59% <0.00%> (-16.39%) ⬇️
pkg/apiserver/event/sync/convert.go 83.33% <66.66%> (-1.48%) ⬇️
pkg/apiserver/interfaces/api/application.go 60.41% <66.66%> (ø)
pkg/apiserver/domain/service/application.go 57.91% <72.64%> (+0.72%) ⬆️
pkg/workflow/hooks/data_passing.go 29.41% <0.00%> (-11.77%) ⬇️
pkg/apiserver/event/sync/workflow_record.go 50.00% <0.00%> (-10.00%) ⬇️
pkg/resourcekeeper/dispatch.go 77.35% <0.00%> (-7.55%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 63.82% <0.00%> (-5.32%) ⬇️
pkg/addon/helper.go 67.70% <0.00%> (-1.57%) ⬇️
pkg/utils/file.go 60.86% <0.00%> (-1.30%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09acc8a...b91fbfe. Read the comment docs.

@barnettZQG barnettZQG changed the title Feat: supports multiple difference alignment modes Feat: supports multiple difference compare modes Jul 7, 2022
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@barnettZQG barnettZQG merged commit b7bf9df into kubevela:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] show difference and add API for sync once from CLI to VelaUX
3 participants