Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support daemonset in component definition #4335

Merged
merged 1 commit into from Jul 7, 2022

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Jul 7, 2022

Signed-off-by: Somefive yd219913@alibaba-inc.com

Description of your changes

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@Somefive Somefive marked this pull request as draft July 7, 2022 03:03
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #4335 (a43f9ef) into master (fd70aa9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4335   +/-   ##
=======================================
  Coverage   60.49%   60.50%           
=======================================
  Files         343      343           
  Lines       33832    33822   -10     
=======================================
- Hits        20467    20464    -3     
+ Misses      10679    10671    -8     
- Partials     2686     2687    +1     
Flag Coverage Δ
apiserver-unittests 34.52% <ø> (+0.04%) ⬆️
core-unittests 55.37% <ø> (-0.03%) ⬇️
e2e-multicluster-test 20.01% <ø> (-0.06%) ⬇️
e2e-rollout-tests 22.25% <ø> (-0.08%) ⬇️
e2etests 28.43% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/policydefinition/policydefinition_controller.go 64.21% <0.00%> (-12.64%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 63.82% <0.00%> (-5.32%) ⬇️
pkg/addon/push.go 75.20% <0.00%> (-1.60%) ⬇️
pkg/multicluster/virtual_cluster.go 91.05% <0.00%> (-0.82%) ⬇️
pkg/apiserver/domain/service/addon.go 58.69% <0.00%> (-0.73%) ⬇️
...dev/v1alpha2/application/application_controller.go 84.66% <0.00%> (-0.62%) ⬇️
pkg/addon/utils.go 72.57% <0.00%> (-0.58%) ⬇️
pkg/workflow/workflow.go 84.14% <0.00%> (-0.22%) ⬇️
cmd/core/main.go 9.34% <0.00%> (-0.04%) ⬇️
pkg/apiserver/domain/service/application.go 57.38% <0.00%> (+0.19%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd70aa9...a43f9ef. Read the comment docs.

@Somefive Somefive marked this pull request as ready for review July 7, 2022 03:15
@Somefive Somefive changed the title Feat: enhance webservice by supporting daemonset Feat: support daemonset in component definition Jul 7, 2022
@Somefive Somefive force-pushed the feat/enhance-webservice branch 2 times, most recently from aa94584 to 30fbf2f Compare July 7, 2022 08:43
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit 201f68c into kubevela:master Jul 7, 2022
@Somefive Somefive deleted the feat/enhance-webservice branch June 20, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants