Feat: velaux support override policy #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyikewxgm
requested review from
barnettZQG,
yangsoon and
FogDong
as code owners
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> add comments Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
wangyikewxgm
force-pushed
the
apiserver-override-policy
branch
from
65fc032
to
b447b13
Compare
Codecov Report
@@ Coverage Diff @@
## master #4352 +/- ##
==========================================
+ Coverage 60.49% 61.09% +0.60%
==========================================
Files 343 345 +2
Lines 33832 33990 +158
==========================================
+ Hits 20467 20767 +300
+ Misses 10679 10498 -181
- Partials 2686 2725 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
wonderflow
reviewed
Jul 11, 2022
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix in the middle of work Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> add test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
wangyikewxgm
force-pushed
the
apiserver-override-policy
branch
from
24ecaea
to
3f28fcc
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
wangyikewxgm
force-pushed
the
apiserver-override-policy
branch
from
9b264e4
to
8d97ca2
Compare
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> reverse flacky test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix goling Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
wangyikewxgm
force-pushed
the
apiserver-override-policy
branch
from
8d97ca2
to
195b9d7
Compare
barnettZQG
reviewed
Jul 14, 2022
| } | ||
| } | ||
| // the target policy isn't exist yet, put it in. | ||
| return res[:i], len(c) != i |
There was a problem hiding this comment.
len(c) != i it will only be true?
There was a problem hiding this comment.
if len(c) != i, that's mean target policy exist in the list, this function has delete it from returned result, and outer caller should update with it.
barnettZQG
reviewed
Jul 14, 2022
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 楚岳 wangyike.wyk@alibaba-inc.com
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer