Feat: add status check for expose trait #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
requested review from
barnettZQG,
wonderflow and
leejanee
as code owners
wonderflow
approved these changes
Jul 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #4356 +/- ##
==========================================
+ Coverage 54.69% 60.55% +5.85%
==========================================
Files 247 343 +96
Lines 22779 33910 +11131
==========================================
+ Hits 12459 20533 +8074
- Misses 8796 10684 +1888
- Partials 1524 2693 +1169
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Somefive
force-pushed
the
feat/add-status-for-expose
branch
from
7ed835f
to
6722efd
Compare
barnettZQG
reviewed
Jul 12, 2022
| import ( | ||
| "strconv" | ||
| ) | ||
|
|
||
| expose: { |
There was a problem hiding this comment.
If this trait is ready, please remove the ui-hidden label.
There was a problem hiding this comment.
Why the previous version is not ready?
There was a problem hiding this comment.
No developer to test it.
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
feat/add-status-for-expose
branch
from
6722efd
to
7c06d93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Somefive yd219913@alibaba-inc.com
Description of your changes
Add status check for expose trait.
If the expose service is LoadBalancer, the health check will wait the ingress ip to be available.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer