Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the project manager no permission to query the project base info #4380

Merged
merged 1 commit into from Jul 14, 2022

Conversation

barnettZQG
Copy link
Collaborator

Signed-off-by: barnettZQG barnett.zqg@gmail.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #4380 (cda3e36) into master (8571aa7) will increase coverage by 15.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #4380       +/-   ##
===========================================
+ Coverage   46.04%   61.05%   +15.01%     
===========================================
  Files         308      344       +36     
  Lines       29567    33902     +4335     
===========================================
+ Hits        13613    20698     +7085     
+ Misses      14302    10492     -3810     
- Partials     1652     2712     +1060     
Flag Coverage Δ
apiserver-unittests 35.04% <100.00%> (?)
core-unittests 56.03% <ø> (-0.06%) ⬇️
e2e-multicluster-test 19.88% <0.00%> (-0.06%) ⬇️
e2e-rollout-tests 22.29% <ø> (+0.07%) ⬆️
e2etests 28.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/service/rbac.go 69.95% <100.00%> (+67.20%) ⬆️
...tepdefinition/workflowstepdefinition_controller.go 69.14% <0.00%> (-7.45%) ⬇️
...es/policydefinition/policydefinition_controller.go 64.21% <0.00%> (-5.27%) ⬇️
pkg/workflow/providers/multicluster/deploy.go 77.52% <0.00%> (-2.25%) ⬇️
...kg/workflow/providers/multicluster/multicluster.go 81.25% <0.00%> (-2.09%) ⬇️
pkg/multicluster/virtual_cluster.go 91.05% <0.00%> (-0.82%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 65.77% <0.00%> (ø)
pkg/apiserver/interfaces/api/target.go 43.80% <0.00%> (ø)
pkg/apiserver/interfaces/api/application.go 60.41% <0.00%> (ø)
pkg/apiserver/interfaces/api/interfaces.go 100.00% <0.00%> (ø)
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8571aa7...cda3e36. Read the comment docs.

Project: project.Name,
}, &model.Role{
Name: "project-admin",
Alias: "Project Admin",
Permissions: []string{"project-read", "app-management", "env-management", "role-management", "configuration-read"},
Permissions: []string{"project-view", "app-management", "env-management", "role-management", "configuration-read"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between view and read

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission project-read does not exist, there only is project-view in the latest version.

@barnettZQG barnettZQG merged commit e52ae78 into kubevela:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants