Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ignore save when source is local path #4417

Merged
merged 1 commit into from Jul 21, 2022

Conversation

ZhongsJie
Copy link
Contributor

@ZhongsJie ZhongsJie commented Jul 20, 2022

Signed-off-by: ZhongsJie zhongsjie@cmbchina.com

Description of your changes

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #4417 (272564b) into master (ab6c1a5) will decrease coverage by 41.65%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #4417       +/-   ##
===========================================
- Coverage   61.49%   19.84%   -41.66%     
===========================================
  Files         347      309       -38     
  Lines       34255    29620     -4635     
===========================================
- Hits        21065     5877    -15188     
- Misses      10455    22686    +12231     
+ Partials     2735     1057     -1678     
Flag Coverage Δ
apiserver-e2etests ?
apiserver-unittests ?
core-unittests ?
e2e-multicluster-test 19.84% <0.00%> (+0.03%) ⬆️
e2e-rollout-tests ?
e2etests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/load.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/utils/sanitize.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/addon/addon.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/addon/reader_memory.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/config/project.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/apiserver/utils/version.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/workflow/providers/time/date.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/apiserver/domain/service/tags.go 0.00% <0.00%> (-100.00%) ⬇️
apis/core.oam.dev/v1alpha2/application_types.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/controller/common/rollout/workloads/common.go 0.00% <0.00%> (-97.11%) ⬇️
... and 262 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6c1a5...272564b. Read the comment docs.

Signed-off-by: ZhongsJie <zhongsjie@gmail.com>
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow merged commit 285a5cc into kubevela:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants