Feat: support to sync the revision and the workflow status #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
barnettZQG
requested review from
yangsoon,
FogDong,
wonderflow,
leejanee and
Somefive
as code owners
FogDong
reviewed
Jul 21, 2022
wonderflow
approved these changes
Jul 21, 2022
Codecov Report
@@ Coverage Diff @@
## master #4419 +/- ##
==========================================
+ Coverage 59.38% 59.94% +0.56%
==========================================
Files 342 347 +5
Lines 34115 34381 +266
==========================================
+ Hits 20258 20611 +353
+ Misses 11201 11024 -177
- Partials 2656 2746 +90
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
FogDong
reviewed
Jul 21, 2022
| klog.ErrorS(err, "failed to get controller revision", "oam app name", appName, "workflow name", record.WorkflowName, "record name", record.Name) | ||
| var revision = &model.ApplicationRevision{AppPrimaryKey: record.AppPrimaryKey, Version: record.RevisionPrimaryKey} | ||
| if err := w.Store.Get(ctx, revision); err != nil { | ||
| log.Logger.Errorf("failed to get the application revision from database %s", err.Error()) |
There was a problem hiding this comment.
If the application revision is not found, set the record status to failure.
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
FogDong
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: barnettZQG barnett.zqg@gmail.com
Description of your changes
ux.oam.dev/from-namespaceapp.oam.dev/source-of-truthux.oam.dev/synced-generationFixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer