-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: address failure when rendering addon API schemas #4433
Fix: address failure when rendering addon API schemas #4433
Conversation
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #4433 +/- ##
==========================================
+ Coverage 59.47% 61.49% +2.02%
==========================================
Files 343 348 +5
Lines 34247 34389 +142
==========================================
+ Hits 20368 21149 +781
+ Misses 11199 10502 -697
- Partials 2680 2738 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Successfully created backport PR #4445 for |
Signed-off-by: Charlie Chiang charlie_c_0129@outlook.com
Description of your changes
After the introduction of global addon parameters, rendering APISchemas will fail:
This is because it is still reading the legacy paramter.cue. But we are using global parameters, so there is nothing inside the legacy parameter.
Now it will read the global parameter first.
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Tests for the new addon structure have been added to prevent regressions.
Special notes for your reviewer
Core changes are in
pkg/addon/addon.go