Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support outputs for addon #4444

Merged
merged 2 commits into from Jul 25, 2022

Conversation

wangyikewxgm
Copy link
Collaborator

@wangyikewxgm wangyikewxgm commented Jul 25, 2022

Signed-off-by: 楚岳 wangyike.wyk@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #4444 (5613250) into master (572fba3) will increase coverage by 1.80%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #4444      +/-   ##
==========================================
+ Coverage   59.51%   61.32%   +1.80%     
==========================================
  Files         343      348       +5     
  Lines       34285    34446     +161     
==========================================
+ Hits        20405    21124     +719     
+ Misses      11188    10567     -621     
- Partials     2692     2755      +63     
Flag Coverage Δ
apiserver-e2etests 27.66% <45.83%> (+0.11%) ⬆️
apiserver-unittests 40.18% <ø> (-0.02%) ⬇️
core-unittests 56.50% <66.66%> (+0.12%) ⬆️
e2e-multicluster-test 19.71% <0.00%> (?)
e2e-rollout-tests 22.88% <ø> (+<0.01%) ⬆️
e2etests 29.08% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/addon.go 62.55% <25.00%> (-0.46%) ⬇️
pkg/addon/render.go 77.62% <86.66%> (+1.28%) ⬆️
pkg/addon/utils.go 72.31% <100.00%> (-0.42%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 57.10% <0.00%> (-15.08%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 38.35% <0.00%> (-4.11%) ⬇️
pkg/resourcekeeper/dispatch.go 77.35% <0.00%> (-3.78%) ⬇️
pkg/apiserver/event/sync/store.go 66.66% <0.00%> (-2.23%) ⬇️
pkg/apiserver/event/sync/convert/convert.go 81.02% <0.00%> (-2.19%) ⬇️
pkg/addon/push.go 75.20% <0.00%> (-1.60%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572fba3...5613250. Read the comment docs.

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@wonderflow wonderflow added the backport release-1.5 add this label will automatically backport this PR to release-1.5 branch label Jul 25, 2022
pkg/addon/render.go Outdated Show resolved Hide resolved
pkg/addon/addon.go Outdated Show resolved Hide resolved
pkg/addon/render.go Outdated Show resolved Hide resolved
pkg/addon/render.go Outdated Show resolved Hide resolved
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix comments

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@github-actions
Copy link

Successfully created backport PR #4457 for release-1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.5 add this label will automatically backport this PR to release-1.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants