Fix: The apply failure error is ignored when the workflow is executed #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangsoon
added
backport release-1.2
Signed-off-by: yangsoon <songyang.song@alibaba-inc.com>
yangsoon
added
the
backport release-1.5
Somefive
approved these changes
Jul 25, 2022
wonderflow
reviewed
Jul 25, 2022
| @@ -134,7 +134,7 @@ func (h *provider) ApplyInParallel(ctx wfContext.Context, v *value.Value, act ty | |||
| deployCtx := multicluster.ContextWithClusterName(context.Background(), cluster) | |||
| deployCtx = auth.ContextWithUserInfo(deployCtx, h.app) | |||
| if err = h.apply(deployCtx, cluster, common.WorkflowResourceCreator, workloads...); err != nil { | |||
| return v.FillObject(err, "err") | |||
| return err | |||
Codecov Report
@@ Coverage Diff @@
## master #4455 +/- ##
===========================================
- Coverage 61.58% 49.63% -11.95%
===========================================
Files 348 286 -62
Lines 34425 31224 -3201
===========================================
- Hits 21201 15499 -5702
- Misses 10467 13518 +3051
+ Partials 2757 2207 -550
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
FogDong
approved these changes
Jul 25, 2022
|
Successfully created backport PR #4459 for |
|
Successfully created backport PR #4460 for |
|
Successfully created backport PR #4461 for |
|
Successfully created backport PR #4462 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer