Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: delete multi apps from vela delete cli command #4484

Merged
merged 1 commit into from Jul 27, 2022

Conversation

ArenaSu
Copy link
Contributor

@ArenaSu ArenaSu commented Jul 27, 2022

Signed-off-by: suxiang 704427617@qq.com

Description of your changes

Fixes #4271

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

vela delete vela-app-01 vela-app-02 vela-app-03
vela delete vela-app-01 vela-app-02 vela-app-03 -y
vela delete vela-app-01 vela-app-02 vela-app-03 -y -w -f
vela delete vela-app-01 vela-app-02 vela-app-03 -y -w

Special notes for your reviewer

Signed-off-by: suxiang <704427617@qq.com>
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

@wonderflow wonderflow added the backport release-1.5 add this label will automatically backport this PR to release-1.5 branch label Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #4484 (957da65) into master (4283a0c) will decrease coverage by 1.79%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4484      +/-   ##
==========================================
- Coverage   61.43%   59.64%   -1.80%     
==========================================
  Files         348      343       -5     
  Lines       34510    34370     -140     
==========================================
- Hits        21202    20499     -703     
- Misses      10537    11172     +635     
+ Partials     2771     2699      -72     
Flag Coverage Δ
apiserver-e2etests 27.53% <ø> (+0.04%) ⬆️
apiserver-unittests 40.28% <ø> (ø)
core-unittests 56.48% <ø> (+0.02%) ⬆️
e2e-multicluster-test ?
e2e-rollout-tests 22.86% <ø> (-0.01%) ⬇️
e2etests 29.36% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/utils/actions.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/auth/identity.go 6.12% <0.00%> (-69.39%) ⬇️
pkg/client/delegating_handler_client.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/resourcetracker/tree.go 17.89% <0.00%> (-57.37%) ⬇️
pkg/policy/envbinding/placement.go 35.00% <0.00%> (-55.00%) ⬇️
pkg/oam/auxiliary.go 30.00% <0.00%> (-53.34%) ⬇️
pkg/auth/kubeconfig.go 0.00% <0.00%> (-50.74%) ⬇️
pkg/resourcekeeper/containsresources.go 37.50% <0.00%> (-37.50%) ⬇️
pkg/auth/privileges.go 37.30% <0.00%> (-31.75%) ⬇️
pkg/utils/file.go 25.00% <0.00%> (-30.77%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4283a0c...957da65. Read the comment docs.

Copy link
Member

@charlie0129 charlie0129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@github-actions
Copy link

Successfully created backport PR #4486 for release-1.5.

@ArenaSu ArenaSu deleted the feat-delete-multi-apps branch July 28, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.5 add this label will automatically backport this PR to release-1.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] support delete several applications in one command
4 participants