-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: delete multi apps from vela delete cli command #4484
Conversation
Signed-off-by: suxiang <704427617@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job
Codecov Report
@@ Coverage Diff @@
## master #4484 +/- ##
==========================================
- Coverage 61.43% 59.64% -1.80%
==========================================
Files 348 343 -5
Lines 34510 34370 -140
==========================================
- Hits 21202 20499 -703
- Misses 10537 11172 +635
+ Partials 2771 2699 -72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Successfully created backport PR #4486 for |
Signed-off-by: suxiang 704427617@qq.com
Description of your changes
Fixes #4271
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer