Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: repeat query configuration type #4492

Merged
merged 1 commit into from Jul 28, 2022
Merged

Fix: repeat query configuration type #4492

merged 1 commit into from Jul 28, 2022

Conversation

ghostloda
Copy link
Contributor

Description of your changes

Fix: Repeat query configuration type #4487

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #4492 (a596e5d) into master (b95980a) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head a596e5d differs from pull request most recent head 5c048b3. Consider uploading reports for the commit 5c048b3 to get more accurate results

@@            Coverage Diff             @@
##           master    #4492      +/-   ##
==========================================
- Coverage   61.50%   61.43%   -0.08%     
==========================================
  Files         348      348              
  Lines       34510    34512       +2     
==========================================
- Hits        21227    21203      -24     
- Misses      10520    10535      +15     
- Partials     2763     2774      +11     
Flag Coverage Δ
apiserver-e2etests 27.58% <0.00%> (+0.15%) ⬆️
apiserver-unittests 40.29% <0.00%> (+<0.01%) ⬆️
core-unittests 56.39% <ø> (-0.16%) ⬇️
e2e-multicluster-test 19.67% <0.00%> (-0.09%) ⬇️
e2e-rollout-tests 22.86% <ø> (-0.06%) ⬇️
e2etests 29.22% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/service/config.go 68.03% <0.00%> (-0.98%) ⬇️
pkg/addon/registry.go 37.34% <0.00%> (-15.67%) ⬇️
...es/policydefinition/policydefinition_controller.go 64.21% <0.00%> (-12.64%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 70.52% <0.00%> (-7.37%) ⬇️
...ponentdefinition/componentdefinition_controller.go 80.00% <0.00%> (-5.56%) ⬇️
pkg/workflow/providers/multicluster/deploy.go 78.02% <0.00%> (-2.20%) ⬇️
...kg/workflow/providers/multicluster/multicluster.go 81.25% <0.00%> (-2.09%) ⬇️
...dev/v1alpha2/application/application_controller.go 84.66% <0.00%> (-1.85%) ⬇️
pkg/multicluster/virtual_cluster.go 91.05% <0.00%> (-0.82%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 71.88% <0.00%> (-0.58%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95980a...5c048b3. Read the comment docs.

@barnettZQG
Copy link
Collaborator

@ghostloda Thanks for your contribution, Please set the DCO.

git commit -s -m "xxx"

@barnettZQG barnettZQG added the backport release-1.5 add this label will automatically backport this PR to release-1.5 branch label Jul 28, 2022
Signed-off-by: ghostloda <78798447@qq.com>
@ghostloda
Copy link
Contributor Author

@ghostloda Thanks for your contribution, Please set the DCO.

git commit -s -m "xxx"

ok

@github-actions
Copy link

Successfully created backport PR #4494 for release-1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.5 add this label will automatically backport this PR to release-1.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants