Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add http status and code from http cmd run #4516

Merged
merged 6 commits into from Aug 2, 2022

Conversation

ArenaSu
Copy link
Contributor

@ArenaSu ArenaSu commented Aug 1, 2022

Signed-off-by: suxiang 704427617@qq.com

Description of your changes

Fixes #3157

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: suxiang <704427617@qq.com>
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #4516 (20ae7f2) into master (976d683) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4516      +/-   ##
==========================================
- Coverage   61.62%   61.35%   -0.27%     
==========================================
  Files         348      348              
  Lines       34478    34473       -5     
==========================================
- Hits        21246    21151      -95     
- Misses      10464    10544      +80     
- Partials     2768     2778      +10     
Flag Coverage Δ
apiserver-e2etests 27.66% <0.00%> (-0.07%) ⬇️
apiserver-unittests 40.28% <ø> (+0.03%) ⬆️
core-unittests 56.55% <100.00%> (-0.07%) ⬇️
e2e-multicluster-test 19.90% <0.00%> (+0.05%) ⬆️
e2e-rollout-tests 23.20% <0.00%> (+<0.01%) ⬆️
e2etests 27.93% <0.00%> (-1.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/builtin/http/http.go 66.25% <100.00%> (+0.42%) ⬆️
.../core.oam.dev/v1beta1/componentdefinition_types.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/client/delegating_client.go 66.66% <0.00%> (-18.52%) ⬇️
pkg/webhook/utils/utils.go 23.07% <0.00%> (-15.39%) ⬇️
...ponentdefinition/componentdefinition_controller.go 72.22% <0.00%> (-13.34%) ⬇️
pkg/appfile/template.go 44.06% <0.00%> (-11.87%) ⬇️
...kg/apiserver/infrastructure/datastore/datastore.go 66.66% <0.00%> (-11.12%) ⬇️
...v/v1alpha2/componentdefinition/mutating_handler.go 64.00% <0.00%> (-10.00%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 40.32% <0.00%> (-9.68%) ⬇️
....oam.dev/v1alpha2/application/assemble/assemble.go 65.24% <0.00%> (-5.68%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976d683...20ae7f2. Read the comment docs.

Signed-off-by: suxiang <704427617@qq.com>
@ArenaSu ArenaSu requested a review from FogDong as a code owner August 2, 2022 01:37
pkg/builtin/http/http.go Outdated Show resolved Hide resolved
Signed-off-by: suxiang <704427617@qq.com>
Signed-off-by: suxiang <704427617@qq.com>
Signed-off-by: suxiang <704427617@qq.com>
Signed-off-by: suxiang <704427617@qq.com>
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@wonderflow wonderflow added the backport release-1.5 add this label will automatically backport this PR to release-1.5 branch label Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Successfully created backport PR #4528 for release-1.5.

@ArenaSu ArenaSu deleted the feat-add-http-status-and-code branch August 2, 2022 08:42
@Somefive Somefive mentioned this pull request Aug 8, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.5 add this label will automatically backport this PR to release-1.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] return http response status in pkg/builtin/http/http.go HTTPCmd.Run
4 participants