-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: report the manifest name when addon enabling failed #4545
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4545 +/- ##
==========================================
+ Coverage 60.93% 61.52% +0.59%
==========================================
Files 348 348
Lines 34515 34515
==========================================
+ Hits 21030 21236 +206
+ Misses 10747 10500 -247
- Partials 2738 2779 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: ghostloda <78798447@qq.com>
Co-authored-by: Jianbo Sun <wonderflow@icloud.com> Signed-off-by: ghostloda <78798447@qq.com>
Co-authored-by: Charlie Chiang <charlie_c_0129@outlook.com> Signed-off-by: ghostloda <78798447@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Successfully created backport PR #4547 for |
Signed-off-by: ghostloda 78798447@qq.com
Description of your changes
Fixes #2982
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
./vela addon enable catalog-master/addons/velaux/
enable addon by local dir: catalog-master/addons/velaux/
W0803 10:13:47.394796 41115 render.go:194] Application name velaux will be overwritten with addon-velaux. Consider removing metadata.name in template.
Error: render addon definitions' schema fail: error rendering file addon-uischema-velaux.yaml: yaml: mapping values are not allowed in this context
Special notes for your reviewer