Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: report the manifest name when addon enabling failed #4545

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Feat: report the manifest name when addon enabling failed #4545

merged 3 commits into from
Aug 3, 2022

Conversation

ghostloda
Copy link
Contributor

Signed-off-by: ghostloda 78798447@qq.com

Description of your changes

Fixes #2982

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

./vela addon enable catalog-master/addons/velaux/
enable addon by local dir: catalog-master/addons/velaux/
W0803 10:13:47.394796 41115 render.go:194] Application name velaux will be overwritten with addon-velaux. Consider removing metadata.name in template.
Error: render addon definitions' schema fail: error rendering file addon-uischema-velaux.yaml: yaml: mapping values are not allowed in this context

Special notes for your reviewer

pkg/addon/addon.go Outdated Show resolved Hide resolved
pkg/addon/addon.go Outdated Show resolved Hide resolved
pkg/addon/addon.go Outdated Show resolved Hide resolved
pkg/addon/addon.go Outdated Show resolved Hide resolved
pkg/addon/addon.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #4545 (67f34ac) into master (7964ec9) will increase coverage by 0.59%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #4545      +/-   ##
==========================================
+ Coverage   60.93%   61.52%   +0.59%     
==========================================
  Files         348      348              
  Lines       34515    34515              
==========================================
+ Hits        21030    21236     +206     
+ Misses      10747    10500     -247     
- Partials     2738     2779      +41     
Flag Coverage Δ
apiserver-e2etests 28.06% <0.00%> (-0.02%) ⬇️
apiserver-unittests 40.31% <ø> (-0.01%) ⬇️
core-unittests 56.62% <14.28%> (-0.10%) ⬇️
e2e-multicluster-test 20.31% <0.00%> (-0.05%) ⬇️
e2e-rollout-tests 23.25% <ø> (-0.06%) ⬇️
e2etests 28.12% <ø> (+2.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/addon.go 62.42% <0.00%> (ø)
pkg/addon/render.go 74.13% <0.00%> (ø)
pkg/addon/utils.go 73.24% <100.00%> (ø)
...es/policydefinition/policydefinition_controller.go 69.47% <0.00%> (-7.37%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-7.37%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 63.82% <0.00%> (-5.32%) ⬇️
pkg/multicluster/cluster_management.go 36.02% <0.00%> (-2.58%) ⬇️
pkg/apiserver/event/sync/convert/convert.go 81.02% <0.00%> (-2.19%) ⬇️
...ler/core.oam.dev/v1alpha2/application/generator.go 85.08% <0.00%> (-0.88%) ⬇️
pkg/controller/utils/capability.go 77.82% <0.00%> (-0.45%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7964ec9...67f34ac. Read the comment docs.

pkg/addon/render.go Outdated Show resolved Hide resolved
pkg/addon/utils.go Outdated Show resolved Hide resolved
@wonderflow wonderflow added the backport release-1.5 add this label will automatically backport this PR to release-1.5 branch label Aug 3, 2022
@charlie0129 charlie0129 changed the title Feat: Report the manifest name when Addon enabling failed Feat: report the manifest name when addon enabling failed Aug 3, 2022
pkg/addon/utils.go Outdated Show resolved Hide resolved
ghostloda and others added 3 commits August 3, 2022 12:55
Signed-off-by: ghostloda <78798447@qq.com>
Co-authored-by: Jianbo Sun <wonderflow@icloud.com>
Signed-off-by: ghostloda <78798447@qq.com>
Co-authored-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: ghostloda <78798447@qq.com>
Copy link
Member

@charlie0129 charlie0129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Successfully created backport PR #4547 for release-1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.5 add this label will automatically backport this PR to release-1.5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report the manifest name when Addon enabling failed
3 participants