Fix: wrong endpoint for LoadBalancer type service #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chivalryq
requested review from
barnettZQG,
wonderflow,
leejanee,
Somefive and
jefree-cat
as code owners
chivalryq
added
the
backport release-1.5
Codecov ReportBase: 45.93% // Head: 60.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4729 +/- ##
===========================================
+ Coverage 45.93% 60.56% +14.62%
===========================================
Files 318 321 +3
Lines 31291 31614 +323
===========================================
+ Hits 14375 19147 +4772
+ Misses 14640 9974 -4666
- Partials 2276 2493 +217
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wonderflow
reviewed
Sep 15, 2022
wonderflow
approved these changes
Sep 15, 2022
chivalryq
force-pushed
the
fix-endpoint
branch
from
49cc7ee
to
1ecfea3
Compare
barnettZQG
reviewed
Sep 15, 2022
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> Fix test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> fix test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
chivalryq
force-pushed
the
fix-endpoint
branch
from
e82c3aa
to
2d511b7
Compare
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
chivalryq
requested review from
zzxwill,
StevenLeiZhang and
charlie0129
as code owners
Somefive
approved these changes
Sep 16, 2022
|
Successfully created backport PR #4738 for |
4 tasks
Somefive
pushed a commit
that referenced
this pull request
Oct 22, 2022
) * Chore: wrong endpoint for LoadBalancer type service(revert #4729) Signed-off-by: barnettZQG <barnett.zqg@gmail.com> * Fix: change the unit test Signed-off-by: barnettZQG <barnett.zqg@gmail.com> Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 22, 2022
Signed-off-by: barnettZQG <barnett.zqg@gmail.com> (cherry picked from commit 92ed75c)
wonderflow
pushed a commit
that referenced
this pull request
Oct 22, 2022
…rvice(revert #4729) (#4906) * Chore: wrong endpoint for LoadBalancer type service(revert #4729) Signed-off-by: barnettZQG <barnett.zqg@gmail.com> (cherry picked from commit 92ed75c) * Fix: change the unit test Signed-off-by: barnettZQG <barnett.zqg@gmail.com> (cherry picked from commit 7985353) Co-authored-by: barnettZQG <barnett.zqg@gmail.com>
tangoliu
pushed a commit
to tangoliu/kubevela
that referenced
this pull request
Oct 27, 2022
) (kubevela#4902) * Chore: wrong endpoint for LoadBalancer type service(revert kubevela#4729) Signed-off-by: barnettZQG <barnett.zqg@gmail.com> * Fix: change the unit test Signed-off-by: barnettZQG <barnett.zqg@gmail.com> Signed-off-by: barnettZQG <barnett.zqg@gmail.com> Signed-off-by: tangoliu <ltg1019@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Qiaozp qiaozhongpei.qzp@alibaba-inc.com
Description of your changes
When service type is LoadBalancer, the actual exposed port is
port.nodePortin status. per https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/#ServiceSpecTest:
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer