-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: vela dry-run render results should be affected by override policy and deploy workflowstep #4815
Merged
Merged
Feat: vela dry-run render results should be affected by override policy and deploy workflowstep #4815
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ac73bef
[Feature] vela dry-run render results should be affected by override …
cezhang 3ff71d9
multiple input files support; policy,workflow support; new flag: merg…
cezhang 1869ae8
Merge branch 'master' into #4410
cezhang 3496c35
add more tests
cezhang cc43d37
fix comment issues
cezhang e7eec64
add tests
cezhang b44269e
fix e2e
cezhang a7cae69
fix tests
cezhang File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
apiVersion: core.oam.dev/v1beta1 | ||
kind: Application | ||
metadata: | ||
name: testing-app | ||
namespace: default | ||
spec: | ||
components: | ||
- name: testing-dryrun | ||
type: webservice | ||
properties: | ||
image: oamdev/hello-world:v1 | ||
ports: | ||
- port: 8000 | ||
expose: true | ||
traits: | ||
- type: scaler | ||
properties: | ||
replicas: 1 | ||
policies: | ||
- name: target-default | ||
type: topology | ||
properties: | ||
clusters: [ "local" ] | ||
namespace: "default" | ||
- name: target-prod | ||
type: topology | ||
properties: | ||
clusters: [ "local" ] | ||
namespace: "prod" | ||
- name: deploy-ha | ||
type: override | ||
properties: | ||
components: | ||
- type: webservice | ||
traits: | ||
- type: scaler | ||
properties: | ||
replicas: 3 | ||
workflow: | ||
steps: | ||
- name: deploy2default | ||
type: deploy | ||
properties: | ||
policies: [ "target-default" ] | ||
- name: deploy2prod | ||
type: deploy | ||
properties: | ||
policies: [ "target-prod", "deploy-ha" ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
apiVersion: core.oam.dev/v1beta1 | ||
kind: Application | ||
metadata: | ||
name: testing-app | ||
spec: | ||
components: | ||
- name: testing-dryrun | ||
type: webservice | ||
properties: | ||
image: oamdev/hello-world:v1 | ||
ports: | ||
- port: 8000 | ||
expose: true | ||
traits: | ||
- type: scaler | ||
properties: | ||
replicas: 1 | ||
policies: | ||
- name: deploy-ha | ||
type: override | ||
properties: | ||
components: | ||
- type: webservice | ||
traits: | ||
- type: scaler | ||
properties: | ||
replicas: 3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
apiVersion: core.oam.dev/v1beta1 | ||
kind: Application | ||
metadata: | ||
name: testing-app | ||
spec: | ||
components: | ||
- name: testing-dryrun | ||
type: webservice | ||
properties: | ||
image: oamdev/hello-world:v1 | ||
workflow: | ||
steps: | ||
- name: suspend | ||
type: suspend | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for commenting them? You can remove them if they are not in use anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already move to suite_test BeforeSuite function, my testcase needs this setting as well. Cannot guarantee which testcase invoked first, if both testcase have this setting, error show.