Fix: prevent rerun app while upgrade due to old apprev lack app workflow #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
requested review from
FogDong,
barnettZQG and
wonderflow
as code owners
Somefive
changed the title
Somefive
force-pushed
the
fix/rerun-app-when-upgrade-due-to-lack-of-workflow-recording
branch
from
76b7803
to
3e26ad6
Compare
Codecov ReportBase: 60.76% // Head: 60.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4852 +/- ##
==========================================
+ Coverage 60.76% 60.82% +0.05%
==========================================
Files 300 300
Lines 31051 31060 +9
==========================================
+ Hits 18869 18893 +24
+ Misses 9687 9674 -13
+ Partials 2495 2493 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Somefive
added
the
backport release-1.5
… app workflow Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
fix/rerun-app-when-upgrade-due-to-lack-of-workflow-recording
branch
from
3e26ad6
to
40af370
Compare
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-1.5
git worktree add -d .worktree/backport-4852-to-release-1.5 origin/release-1.5
cd .worktree/backport-4852-to-release-1.5
git checkout -b backport-4852-to-release-1.5
ancref=$(git merge-base 913c740a87508d72eedd1b097c71dba6b26da54c 40af3704cc97e72eaf22dde2c58e6769db853001)
git cherry-pick -x $ancref..40af3704cc97e72eaf22dde2c58e6769db853001 |
4 tasks
Somefive
deleted the
fix/rerun-app-when-upgrade-due-to-lack-of-workflow-recording
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Somefive yd219913@alibaba-inc.com
Description of your changes
In version before v1.6.0-alpha.4, applications with revision under v1.5.7 (not released yet) and revision under v1.6.0-alpha.4 (released), application revision (without PublishVersion) does not record workflow in Application Spec inside, which will lead to inequality with revisions created by latest KubeVela.
This PR adds additional rules for bypassing the comparing application workflow when
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer