-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add startup probe trait #5093
Conversation
Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>
Codecov ReportBase: 49.43% // Head: 61.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5093 +/- ##
===========================================
+ Coverage 49.43% 61.20% +11.76%
===========================================
Files 304 306 +2
Lines 33264 45349 +12085
===========================================
+ Hits 16444 27755 +11311
- Misses 14548 14759 +211
- Partials 2272 2835 +563
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
} | ||
} | ||
template: { | ||
patch: spec: template: spec: containers: [...{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we usually use //+patchKey=name, or use [{}, ...]. The [...{}] for patch means the startupProbe will be patched to all containers.
@@ -0,0 +1,22 @@ | |||
apiVersion: core.oam.dev/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the example here align the format: https://github.com/kubevela/kubevela/tree/master/references/docgen/def-doc/trait
They'll be generated as reference doc automatically. https://kubevela.net/docs/end-user/traits/references
Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
* Feat: Add startup probe trait Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com> * Feat: Implemented review comments in startup probe trait Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com> Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>
* Feat: Add startup probe trait Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com> * Feat: Implemented review comments in startup probe trait Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com> Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>
Signed-off-by: Jerome Guionnet jguionnet@guidewire.com
Description of your changes
Feat: Add startup probe trait
See #5092
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Using the usage example provided with the PR