Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add startup probe trait #5093

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Conversation

jguionnet
Copy link
Contributor

@jguionnet jguionnet commented Nov 19, 2022

Signed-off-by: Jerome Guionnet jguionnet@guidewire.com

Description of your changes

Feat: Add startup probe trait

See #5092

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Using the usage example provided with the PR

Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 49.43% // Head: 61.20% // Increases project coverage by +11.76% 🎉

Coverage data is based on head (345168e) compared to base (c89f268).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5093       +/-   ##
===========================================
+ Coverage   49.43%   61.20%   +11.76%     
===========================================
  Files         304      306        +2     
  Lines       33264    45349    +12085     
===========================================
+ Hits        16444    27755    +11311     
- Misses      14548    14759      +211     
- Partials     2272     2835      +563     
Flag Coverage Δ
apiserver-e2etests 35.11% <ø> (?)
apiserver-unittests 36.93% <ø> (-0.23%) ⬇️
core-unittests 55.08% <ø> (-0.13%) ⬇️
e2e-multicluster-test 18.91% <ø> (+0.27%) ⬆️
e2e-rollout-tests 20.51% <ø> (+0.32%) ⬆️
e2etests 25.99% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/core/main.go 0.00% <0.00%> (-10.51%) ⬇️
pkg/resourcekeeper/resourcekeeper.go 67.27% <0.00%> (-8.49%) ⬇️
pkg/velaql/context.go 27.90% <0.00%> (-6.88%) ⬇️
pkg/resourcekeeper/componentrevision.go 58.33% <0.00%> (-5.96%) ⬇️
pkg/utils/util/cmd.go 20.00% <0.00%> (-5.00%) ⬇️
pkg/auth/round_trippers.go 81.81% <0.00%> (-4.85%) ⬇️
pkg/stdlib/packages.go 57.14% <0.00%> (-4.40%) ⬇️
pkg/config/writer/nacos.go 64.70% <0.00%> (-4.37%) ⬇️
pkg/cue/task/process.go 35.71% <0.00%> (-4.29%) ⬇️
pkg/utils/load.go 48.78% <0.00%> (-4.17%) ⬇️
... and 299 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

}
}
template: {
patch: spec: template: spec: containers: [...{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we usually use //+patchKey=name, or use [{}, ...]. The [...{}] for patch means the startupProbe will be patched to all containers.

@@ -0,0 +1,22 @@
apiVersion: core.oam.dev/v1beta1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the example here align the format: https://github.com/kubevela/kubevela/tree/master/references/docgen/def-doc/trait

They'll be generated as reference doc automatically. https://kubevela.net/docs/end-user/traits/references

Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@wonderflow wonderflow merged commit 3b8cd84 into kubevela:master Dec 2, 2022
@jguionnet jguionnet deleted the startupProbe branch December 2, 2022 08:44
barnettZQG pushed a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
* Feat: Add startup probe trait

Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>

* Feat: Implemented review comments in startup probe trait

Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>

Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
* Feat: Add startup probe trait

Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>

* Feat: Implemented review comments in startup probe trait

Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>

Signed-off-by: Jerome Guionnet <jguionnet@guidewire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants