Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support fallback to kubeconfig namespace when env not set #5182

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

wonderflow
Copy link
Collaborator

Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com

Description of your changes

Fixes #5121

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 61.08% // Head: 61.10% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (b97fd9f) compared to base (e63aa44).
Patch coverage: 45.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5182      +/-   ##
==========================================
+ Coverage   61.08%   61.10%   +0.02%     
==========================================
  Files         305      305              
  Lines       45337    45358      +21     
==========================================
+ Hits        27692    27715      +23     
+ Misses      14800    14798       -2     
  Partials     2845     2845              
Flag Coverage Δ
apiserver-e2etests 35.02% <0.00%> (+0.03%) ⬆️
apiserver-unittests 36.87% <ø> (+0.01%) ⬆️
core-unittests 55.10% <45.45%> (+0.06%) ⬆️
e2e-multicluster-test 18.91% <0.00%> (-0.05%) ⬇️
e2e-rollout-tests 20.53% <0.00%> (-0.05%) ⬇️
e2etests 25.97% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/common/args.go 34.21% <42.85%> (+1.95%) ⬆️
pkg/oam/util/helper.go 64.00% <100.00%> (ø)
pkg/apiserver/event/sync/cr2ux.go 45.88% <0.00%> (-4.71%) ⬇️
...es/policydefinition/policydefinition_controller.go 69.51% <0.00%> (-3.66%) ⬇️
pkg/resourcekeeper/gc.go 77.97% <0.00%> (-2.09%) ⬇️
pkg/velaql/providers/query/collector.go 68.80% <0.00%> (-1.84%) ⬇️
...dev/v1alpha2/application/application_controller.go 84.97% <0.00%> (-1.18%) ⬇️
pkg/velaql/providers/query/tree.go 85.27% <0.00%> (-0.40%) ⬇️
pkg/addon/registry.go 51.26% <0.00%> (ø)
pkg/multicluster/virtual_cluster.go 77.28% <0.00%> (+0.36%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@Somefive Somefive merged commit ac9cf58 into kubevela:master Dec 13, 2022
@wonderflow wonderflow deleted the namespace1 branch December 13, 2022 06:54
barnettZQG pushed a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
…vela#5182)

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
…vela#5182)

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] vela cli uses namespace from kubeconfig if env not set
2 participants