-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: optimize controller default value for better performance #5194
Conversation
Codecov ReportBase: 61.12% // Head: 58.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5194 +/- ##
==========================================
- Coverage 61.12% 58.88% -2.25%
==========================================
Files 305 300 -5
Lines 45377 45163 -214
==========================================
- Hits 27738 26593 -1145
- Misses 14788 15772 +984
+ Partials 2851 2798 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> try 2 fix Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e tests Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e tests Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
…ela#5194) * Feat: optimize controller default value for better performance Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * try to fix rollout e2e-test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> try 2 fix Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e tests Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e tests Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> Co-authored-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
…ela#5194) * Feat: optimize controller default value for better performance Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> * try to fix rollout e2e-test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> try 2 fix Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e test Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e tests Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> fix e2e tests Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com> Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com> Co-authored-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com
Description of your changes
Fixes #5050
This PR optimized the default chart value for better performance:
Noteable Changes
applicationRevisionLimit
changes from10
to2
, by default it will reserve only 2 app revisions instead of 10, which mean you don't have many revisions as options for rolling back. If you want to keep the value, you can specify by:optimize.disableComponentRevision
by default, we'll turn off component revision, it will affect users who use the olderrollout
addon, users who're using kruise-rollout won't be affected. If you still want to use it, please specify the paramter when installing/upgrading.Other Changes
definitionRevisionLimit
changes from20
to2
, by default it will reserve only 2 revisions for each definitions instead of 10.featureGates.zstdResourceTracker
by default, the controller will use zstd for resourceTracker compression.featureGates.zstdApplicationRevision
by default, the controller will use zstd for applicationRevision compression.kubeClient.qps
andkubeClient.burst
changes to100
and200
, double sized from older ones.enableFluxcdAddon
deprecated as it's already widely used as being installed as addon.I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer