Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: optimize controller default value for better performance #5194

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

wonderflow
Copy link
Collaborator

@wonderflow wonderflow commented Dec 15, 2022

Signed-off-by: Jianbo Sun jianbo.sjb@alibaba-inc.com

Description of your changes

Fixes #5050

This PR optimized the default chart value for better performance:

Noteable Changes

  • applicationRevisionLimit changes from 10 to 2, by default it will reserve only 2 app revisions instead of 10, which mean you don't have many revisions as options for rolling back. If you want to keep the value, you can specify by:
    helm upgrade --set applicationRevisionLimit=10
    
  • optimize.disableComponentRevision by default, we'll turn off component revision, it will affect users who use the older rollout addon, users who're using kruise-rollout won't be affected. If you still want to use it, please specify the paramter when installing/upgrading.
    helm upgrade --set optimize.disableComponentRevision=false
    

Other Changes

  • definitionRevisionLimit changes from 20 to 2, by default it will reserve only 2 revisions for each definitions instead of 10.
  • featureGates.zstdResourceTracker by default, the controller will use zstd for resourceTracker compression.
  • featureGates.zstdApplicationRevision by default, the controller will use zstd for applicationRevision compression.
  • kubeClient.qps and kubeClient.burst changes to 100 and 200, double sized from older ones.
  • enableFluxcdAddon deprecated as it's already widely used as being installed as addon.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 61.12% // Head: 58.88% // Decreases project coverage by -2.24% ⚠️

Coverage data is based on head (a65f428) compared to base (2b3da03).
Patch has no changes to coverable lines.

❗ Current head a65f428 differs from pull request most recent head 20d727d. Consider uploading reports for the commit 20d727d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5194      +/-   ##
==========================================
- Coverage   61.12%   58.88%   -2.25%     
==========================================
  Files         305      300       -5     
  Lines       45377    45163     -214     
==========================================
- Hits        27738    26593    -1145     
- Misses      14788    15772     +984     
+ Partials     2851     2798      -53     
Flag Coverage Δ
apiserver-e2etests 34.94% <ø> (-0.09%) ⬇️
apiserver-unittests 36.85% <ø> (-0.05%) ⬇️
core-unittests 55.01% <ø> (-0.12%) ⬇️
e2e-multicluster-test ?
e2e-rollout-tests ?
e2etests 25.28% <ø> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/utils/actions.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/auth/identity.go 8.45% <0.00%> (-67.61%) ⬇️
pkg/resourcetracker/tree.go 18.49% <0.00%> (-53.97%) ⬇️
pkg/auth/kubeconfig.go 0.00% <0.00%> (-52.85%) ⬇️
pkg/oam/auxiliary.go 34.78% <0.00%> (-52.18%) ⬇️
pkg/policy/envbinding/placement.go 40.00% <0.00%> (-48.75%) ⬇️
pkg/auth/privileges.go 35.61% <0.00%> (-31.34%) ⬇️
pkg/utils/file.go 25.37% <0.00%> (-26.87%) ⬇️
pkg/utils/system/system.go 8.04% <0.00%> (-25.29%) ⬇️
pkg/utils/strings.go 53.46% <0.00%> (-24.76%) ⬇️
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

try 2 fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e test

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e test

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e tests

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e tests

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@wonderflow wonderflow merged commit c94fa21 into kubevela:master Dec 16, 2022
@wonderflow wonderflow deleted the optimize branch December 16, 2022 09:55
barnettZQG pushed a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
…ela#5194)

* Feat: optimize controller default value for better performance

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

* try to fix rollout e2e-test

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

try 2 fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e test

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e test

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e tests

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e tests

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Co-authored-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
…ela#5194)

* Feat: optimize controller default value for better performance

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>

* try to fix rollout e2e-test

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

try 2 fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e test

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e test

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e tests

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix e2e tests

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Co-authored-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many ApplicationRevision cause controller list/watch api timeout with etcd
4 participants