Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: optimize build push image step #5215

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Dec 20, 2022

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 61.11% // Head: 61.21% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (2832ec6) compared to base (8ef512d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5215      +/-   ##
==========================================
+ Coverage   61.11%   61.21%   +0.10%     
==========================================
  Files         305      305              
  Lines       45448    45448              
==========================================
+ Hits        27774    27820      +46     
+ Misses      14810    14775      -35     
+ Partials     2864     2853      -11     
Flag Coverage Δ
apiserver-e2etests 35.15% <ø> (+0.04%) ⬆️
apiserver-unittests 36.87% <ø> (-0.02%) ⬇️
core-unittests 55.11% <ø> (+0.01%) ⬆️
e2e-multicluster-test 18.94% <ø> (+0.02%) ⬆️
e2e-rollout-tests 20.53% <ø> (-0.01%) ⬇️
e2etests 26.09% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/registry.go 38.65% <0.00%> (-12.61%) ⬇️
pkg/utils/apply/apply.go 86.73% <0.00%> (-1.08%) ⬇️
...ler/core.oam.dev/v1alpha2/application/generator.go 87.08% <0.00%> (-0.83%) ⬇️
pkg/apiserver/domain/service/addon.go 62.21% <0.00%> (-0.52%) ⬇️
pkg/addon/addon.go 64.54% <0.00%> (-0.29%) ⬇️
pkg/controller/utils/capability.go 80.58% <0.00%> (+0.62%) ⬆️
pkg/multicluster/virtual_cluster.go 77.28% <0.00%> (+1.09%) ⬆️
...server/infrastructure/datastore/kubeapi/kubeapi.go 64.54% <0.00%> (+1.10%) ⬆️
pkg/addon/push.go 76.27% <0.00%> (+1.12%) ⬆️
...dev/v1alpha2/application/application_controller.go 86.18% <0.00%> (+1.17%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@wonderflow wonderflow merged commit a5a1a2e into kubevela:master Dec 20, 2022
barnettZQG pushed a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants