Feat: the webservice component has no args parameter #5226 #5227
Conversation
caoxingming
requested review from
Somefive,
barnettZQG,
wonderflow,
FogDong,
leejanee and
jefree-cat
as code owners
|
The commit message should starts with "Feat: " |
caoxingming
changed the title
modified，thanks |
| @@ -185,6 +185,10 @@ spec: | |||
| command: parameter.cmd | |||
| } | |||
|
|
|||
| if parameter["args"] != _|_ { | |||
There was a problem hiding this comment.
I think you should not edit the two Definition yaml files.
Because here is comment in this file "# Code generated by KubeVela templates. DO NOT EDIT. Please edit the original cue file.
"
There was a problem hiding this comment.
it's automatically generated by make reviewable
There was a problem hiding this comment.
we should check in the automatically generated result
no. Not title of PR, but your commit message. Please change your commit message and repush commit. |
Codecov ReportBase: 61.18% // Head: 61.23% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5227 +/- ##
==========================================
+ Coverage 61.18% 61.23% +0.04%
==========================================
Files 305 305
Lines 45681 45681
==========================================
+ Hits 27950 27972 +22
+ Misses 14856 14834 -22
Partials 2875 2875
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Add the args parameter to the webservice component Signed-off-by: xingming01 <whatissoftware@163.com>
caoxingming
force-pushed
the
feat-webservice
branch
from
c3a455b
to
2e7c63f
Compare
…ubevela#5227) Add the args parameter to the webservice component Signed-off-by: xingming01 <whatissoftware@163.com> Signed-off-by: xingming01 <whatissoftware@163.com>
…ubevela#5227) Add the args parameter to the webservice component Signed-off-by: xingming01 <whatissoftware@163.com> Signed-off-by: xingming01 <whatissoftware@163.com>
Add the args parameter to the webservice component
Signed-off-by: xingming01 whatissoftware@163.com
Description of your changes
Fixes #5226
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer