Fix: dry run from revision application patch error #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion lower than the current version Signed-off-by: old.prince <di7zhang@gmail.com>
callmeoldprince
requested review from
barnettZQG,
yangsoon and
FogDong
as code owners
callmeoldprince
changed the title
Codecov ReportBase: 46.87% // Head: 61.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5246 +/- ##
===========================================
+ Coverage 46.87% 61.18% +14.31%
===========================================
Files 303 306 +3
Lines 45625 45767 +142
===========================================
+ Hits 21385 28004 +6619
+ Misses 21555 14871 -6684
- Partials 2685 2892 +207
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
callmeoldprince
changed the title
callmeoldprince
changed the title
callmeoldprince
changed the title
barnettZQG
reviewed
Jan 2, 2023
barnettZQG
added
backport release-1.5
|
Successfully created backport PR #5249 for |
|
Successfully created backport PR #5250 for |
barnettZQG
pushed a commit
to barnettZQG/kubevela
that referenced
this pull request
Jan 30, 2023
…sion lower than the current version (kubevela#5246) Signed-off-by: old.prince <di7zhang@gmail.com> Signed-off-by: old.prince <di7zhang@gmail.com>
zhaohuiweixiao
pushed a commit
to zhaohuiweixiao/kubevela
that referenced
this pull request
Mar 7, 2023
…sion lower than the current version (kubevela#5246) Signed-off-by: old.prince <di7zhang@gmail.com> Signed-off-by: old.prince <di7zhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: old.prince di7zhang@gmail.com
Description of your changes
Fixes:Dry-run from revision application,Problems caused by resource version lower than the current version
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer