Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make the impersonation feature work #5261

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

barnettZQG
Copy link
Collaborator

Signed-off-by: barnettZQG barnett.zqg@gmail.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 61.27% // Head: 61.12% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (08a3a2d) compared to base (5f71d05).
Patch coverage: 48.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5261      +/-   ##
==========================================
- Coverage   61.27%   61.12%   -0.15%     
==========================================
  Files         307      307              
  Lines       46355    46350       -5     
==========================================
- Hits        28404    28332      -72     
- Misses      15027    15099      +72     
+ Partials     2924     2919       -5     
Flag Coverage Δ
apiserver-e2etests 35.50% <48.14%> (-0.08%) ⬇️
apiserver-unittests 36.30% <20.83%> (-0.02%) ⬇️
core-unittests 55.11% <100.00%> (-0.10%) ⬇️
e2e-multicluster-test 18.99% <3.84%> (-0.12%) ⬇️
e2e-rollout-tests 20.66% <8.33%> (+0.02%) ⬆️
e2etests 26.19% <8.33%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/repository/env.go 58.49% <ø> (ø)
pkg/apiserver/interfaces/api/env.go 52.67% <0.00%> (ø)
pkg/apiserver/domain/service/target.go 57.86% <20.00%> (-0.09%) ⬇️
pkg/apiserver/utils/auth.go 63.63% <45.45%> (+4.37%) ⬆️
pkg/apiserver/domain/service/project.go 59.11% <50.00%> (+0.09%) ⬆️
pkg/apiserver/domain/service/env.go 65.36% <60.00%> (+0.27%) ⬆️
pkg/addon/versioned_registry.go 78.88% <100.00%> (ø)
pkg/features/apiserver_features.go 100.00% <100.00%> (ø)
pkg/addon/registry.go 38.65% <0.00%> (-12.61%) ⬇️
...es/policydefinition/policydefinition_controller.go 73.17% <0.00%> (-7.32%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@barnettZQG barnettZQG merged commit ba0a726 into kubevela:master Jan 4, 2023
barnettZQG added a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
* Fix: make the impersonation feature work

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>

* Fix: update the document of the chart

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
* Fix: make the impersonation feature work

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>

* Fix: update the document of the chart

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants