Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support hostpath in storage and vela cli #5265

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Jan 4, 2023

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@wonderflow
Copy link
Collaborator

what can hostpath be used?

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 49.29% // Head: 61.16% // Increases project coverage by +11.86% 🎉

Coverage data is based on head (1b2fb31) compared to base (b2f4e23).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5265       +/-   ##
===========================================
+ Coverage   49.29%   61.16%   +11.86%     
===========================================
  Files         306      307        +1     
  Lines       46337    46355       +18     
===========================================
+ Hits        22844    28351     +5507     
+ Misses      21104    15081     -6023     
- Partials     2389     2923      +534     
Flag Coverage Δ
apiserver-e2etests 35.53% <ø> (?)
apiserver-unittests 36.34% <ø> (+0.02%) ⬆️
core-unittests 55.19% <ø> (-0.02%) ⬇️
e2e-multicluster-test 19.01% <ø> (-0.02%) ⬇️
e2e-rollout-tests 20.64% <ø> (ø)
e2etests 26.07% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tepdefinition/workflowstepdefinition_controller.go 74.11% <0.00%> (-7.06%) ⬇️
...es/policydefinition/policydefinition_controller.go 73.17% <0.00%> (-3.66%) ⬇️
...ler/core.oam.dev/v1alpha2/application/generator.go 87.19% <0.00%> (-0.82%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 72.14% <0.00%> (-0.66%) ⬇️
pkg/controller/utils/capability.go 79.50% <0.00%> (-0.57%) ⬇️
pkg/apiserver/utils/container/container.go 83.33% <0.00%> (ø)
pkg/velaql/providers/query/tree.go 85.27% <0.00%> (+0.26%) ⬆️
pkg/appfile/template.go 54.22% <0.00%> (+0.64%) ⬆️
pkg/multicluster/cluster_management.go 37.23% <0.00%> (+0.79%) ⬆️
pkg/addon/render.go 68.23% <0.00%> (+0.94%) ⬆️
... and 112 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wonderflow wonderflow merged commit 360c9e2 into kubevela:master Jan 5, 2023
barnettZQG pushed a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants