Fix: Index structure map[string]string,Mongo resulting in inconsistent results obtained by filtering non-string type by index. #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmeoldprince
requested review from
barnettZQG,
yangsoon,
FogDong,
wonderflow,
leejanee,
Somefive and
jefree-cat
as code owners
Codecov ReportBase: 61.16% // Head: 61.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5274 +/- ##
==========================================
+ Coverage 61.16% 61.18% +0.02%
==========================================
Files 308 308
Lines 46562 46611 +49
==========================================
+ Hits 28478 28519 +41
+ Misses 15138 15137 -1
- Partials 2946 2955 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
callmeoldprince
force-pushed
the
fix-datastoreindex
branch
2 times, most recently
from
7be2927
to
0ade9ba
Compare
callmeoldprince
force-pushed
the
fix-datastoreindex
branch
from
76a5934
to
25cee15
Compare
callmeoldprince
requested review from
wangyikewxgm,
charlie0129,
zzxwill and
chivalryq
as code owners
callmeoldprince
force-pushed
the
fix-datastoreindex
branch
from
25cee15
to
3a917cb
Compare
barnettZQG
reviewed
Jan 11, 2023
| @@ -25,6 +25,11 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| pkgUtils "github.com/oam-dev/kubevela/pkg/utils" | |||
There was a problem hiding this comment.
Please keep the code style, and move the inner package to last.
There was a problem hiding this comment.
@barnettZQG ok,modify completed
wonderflow
added
the
backport release-1.7
…t results obtained by filtering non-string type by index. Signed-off-by: old.prince <di7zhang@gmail.com>
callmeoldprince
force-pushed
the
fix-datastoreindex
branch
from
20926c3
to
a763d3d
Compare
barnettZQG
approved these changes
Jan 11, 2023
|
Successfully created backport PR #5303 for |
barnettZQG
pushed a commit
to barnettZQG/kubevela
that referenced
this pull request
Jan 30, 2023
…t results obtained by filtering non-string type by index. (kubevela#5274) Signed-off-by: old.prince <di7zhang@gmail.com> Signed-off-by: old.prince <di7zhang@gmail.com>
zhaohuiweixiao
pushed a commit
to zhaohuiweixiao/kubevela
that referenced
this pull request
Mar 7, 2023
…t results obtained by filtering non-string type by index. (kubevela#5274) Signed-off-by: old.prince <di7zhang@gmail.com> Signed-off-by: old.prince <di7zhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: old.prince di7zhang@gmail.com
Description of your changes
Fixes #5263
Value of non-string type stored in mongo is not string.Resulting in inconsistent results obtained by filtering non-string type by index.The reason is that when mongo stores the index is still filtered by string value but the actual value is not a string.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer