Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: keep the workflow data structure in MongoDB #5276

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

barnettZQG
Copy link
Collaborator

Signed-off-by: barnettZQG barnett.zqg@gmail.com

Description of your changes

Fixes #5137

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@barnettZQG barnettZQG added the backport release-1.6 add this label will automatically backport this PR to release-1.6 branch label Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 61.21% // Head: 61.15% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (035d668) compared to base (360c9e2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5276      +/-   ##
==========================================
- Coverage   61.21%   61.15%   -0.07%     
==========================================
  Files         307      307              
  Lines       46350    46350              
==========================================
- Hits        28375    28347      -28     
- Misses      15063    15079      +16     
- Partials     2912     2924      +12     
Flag Coverage Δ
apiserver-e2etests 35.56% <ø> (-0.03%) ⬇️
apiserver-unittests 36.30% <ø> (ø)
core-unittests 55.17% <ø> (-0.03%) ⬇️
e2e-multicluster-test 19.01% <ø> (+0.02%) ⬆️
e2e-rollout-tests 20.66% <ø> (?)
e2etests 26.13% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/model/workflow.go 100.00% <ø> (ø)
pkg/addon/registry.go 38.65% <0.00%> (-12.61%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 51.16% <0.00%> (-9.31%) ⬇️
...es/policydefinition/policydefinition_controller.go 69.51% <0.00%> (-7.32%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 69.41% <0.00%> (-7.06%) ⬇️
pkg/apiserver/domain/service/target.go 57.86% <0.00%> (-3.38%) ⬇️
pkg/apiserver/event/sync/store.go 71.49% <0.00%> (-1.36%) ⬇️
pkg/auth/privileges.go 66.09% <0.00%> (-0.86%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 63.71% <0.00%> (-0.84%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 71.22% <0.00%> (-0.52%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Successfully created backport PR #5283 for release-1.6.

barnettZQG added a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.6 add this label will automatically backport this PR to release-1.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow data structure changes lead to page display errors
2 participants