Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: upgrade cluster-gateway to support client-identity-exchange config #5284

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Jan 6, 2023

Signed-off-by: Somefive yd219913@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 61.16% // Head: 61.11% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (a8ba40d) compared to base (3a917cb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5284      +/-   ##
==========================================
- Coverage   61.16%   61.11%   -0.05%     
==========================================
  Files         308      308              
  Lines       46562    46562              
==========================================
- Hits        28478    28457      -21     
- Misses      15138    15148      +10     
- Partials     2946     2957      +11     
Flag Coverage Δ
apiserver-e2etests 32.49% <ø> (+0.11%) ⬆️
apiserver-unittests 36.24% <ø> (+0.03%) ⬆️
core-unittests 55.17% <ø> (+0.03%) ⬆️
e2e-multicluster-test 19.00% <ø> (-0.14%) ⬇️
e2e-rollout-tests 20.72% <ø> (-0.01%) ⬇️
e2etests 26.36% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aits/traitdefinition/traitdefinition_controller.go 69.41% <0.00%> (-7.06%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 86.07% <0.00%> (-2.85%) ⬇️
pkg/multicluster/cluster_management.go 37.23% <0.00%> (-2.66%) ⬇️
pkg/oam/util/helper.go 61.91% <0.00%> (-2.09%) ⬇️
pkg/controller/utils/capability.go 78.93% <0.00%> (-1.71%) ⬇️
pkg/cue/definition/template.go 66.46% <0.00%> (-1.50%) ⬇️
...dev/v1alpha2/application/application_controller.go 85.11% <0.00%> (-1.17%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 71.71% <0.00%> (-1.10%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 70.83% <0.00%> (-0.91%) ⬇️
pkg/multicluster/virtual_cluster.go 76.19% <0.00%> (-0.74%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@barnettZQG barnettZQG merged commit 69293f4 into kubevela:master Jan 6, 2023
barnettZQG pushed a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
…fig (kubevela#5284)

Signed-off-by: Somefive <yd219913@alibaba-inc.com>

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
…fig (kubevela#5284)

Signed-off-by: Somefive <yd219913@alibaba-inc.com>

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants