-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: use mock server in addon tests #5286
Conversation
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Codecov ReportBase: 61.15% // Head: 61.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5286 +/- ##
==========================================
- Coverage 61.15% 61.11% -0.05%
==========================================
Files 308 308
Lines 46562 46562
==========================================
- Hits 28476 28456 -20
- Misses 15126 15160 +34
+ Partials 2960 2946 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Do we need backport this PR to previous version? /cc @wangyikewxgm |
Yes, this is a general problem. |
Successfully created backport PR #5289 for |
Successfully created backport PR #5290 for |
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com> Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Signed-off-by: Charlie Chiang charlie_c_0129@outlook.com
Description of your changes
The addon helper tests previously used real upstream KubeVela repository, which will sometimes change and make this test flacky.
This PR sets up a local mock server instead, in an effort to make this test more stable.
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer