-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: enhance the application synchronizer #5299
Conversation
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Codecov ReportBase: 47.12% // Head: 61.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5299 +/- ##
===========================================
+ Coverage 47.12% 61.05% +13.92%
===========================================
Files 305 308 +3
Lines 46427 46572 +145
===========================================
+ Hits 21881 28436 +6555
+ Misses 21805 15189 -6616
- Partials 2741 2947 +206
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
1954fbf
to
ad43fb5
Compare
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
ad43fb5
to
c3e896f
Compare
Successfully created backport PR #5305 for |
* Feat: enhance the application synchronizer Signed-off-by: barnettZQG <barnett.zqg@gmail.com> * Fix: e2e test case Signed-off-by: barnettZQG <barnett.zqg@gmail.com> * Fix: the unit test case Signed-off-by: barnettZQG <barnett.zqg@gmail.com> Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
* Feat: enhance the application synchronizer Signed-off-by: barnettZQG <barnett.zqg@gmail.com> * Fix: e2e test case Signed-off-by: barnettZQG <barnett.zqg@gmail.com> * Fix: the unit test case Signed-off-by: barnettZQG <barnett.zqg@gmail.com> Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG barnett.zqg@gmail.com
Description of your changes
Before, we use the generation number as the cache key. If users only change the publish version to rerun the workflow, the application spec does not change, the generation does not change, so the revision and the workflow record can not be synced.
In PR #5282 try to use the resource version as the cache key. The resource version changes constantly When the application workflow running. We did not need to sync the record status in the application synchronizer, so, this resulted in excessive database requests.
Now, we use the revision as the cache key. When the new revision is generated the app synchronizer should resync the application.
This PR makes the API server use the unitive auth client to request the kube API.
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer