Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: velaql support indexing into exported array field #5320

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

hnd4r7
Copy link
Contributor

@hnd4r7 hnd4r7 commented Jan 11, 2023

Signed-off-by: hnd4r7 307365651@qq.com

Description of your changes

Support indexing array field in the exported value of the velaql query result to satisfy certain needs such as getting the cluster name of the first pod in component-pod-view.

Before,
image
After,
image

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@hnd4r7 hnd4r7 changed the title velaql support export array velaql support indexing into exported array field Jan 11, 2023
@hnd4r7 hnd4r7 changed the title velaql support indexing into exported array field Feat: velaql support indexing into exported array field Jan 11, 2023
@hnd4r7 hnd4r7 force-pushed the feat/velaql-support-export-array branch from eb4c63a to 7f693aa Compare January 11, 2023 12:22
Signed-off-by: hnd4r7 <307365651@qq.com>
@hnd4r7 hnd4r7 force-pushed the feat/velaql-support-export-array branch from 7f693aa to 441d8f0 Compare January 11, 2023 12:24
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 46.37% // Head: 46.21% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (eb4c63a) compared to base (c4f3026).
Patch has no changes to coverable lines.

❗ Current head eb4c63a differs from pull request most recent head 441d8f0. Consider uploading reports for the commit 441d8f0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5320      +/-   ##
==========================================
- Coverage   46.37%   46.21%   -0.17%     
==========================================
  Files         294      251      -43     
  Lines       45744    42245    -3499     
==========================================
- Hits        21214    19523    -1691     
+ Misses      22205    20515    -1690     
+ Partials     2325     2207     -118     
Flag Coverage Δ
apiserver-unittests 36.25% <ø> (-0.01%) ⬇️
core-unittests 55.26% <ø> (-0.05%) ⬇️
e2e-rollout-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/velaql/parse.go 68.42% <ø> (ø)
pkg/workflow/workflow.go 0.00% <0.00%> (-88.24%) ⬇️
...v/v1alpha2/componentdefinition/mutating_handler.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/utils/json.go 0.00% <0.00%> (-57.15%) ⬇️
pkg/resourcekeeper/containsresources.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/multicluster/utils.go 15.73% <0.00%> (-44.95%) ⬇️
cmd/core/app/server.go 15.42% <0.00%> (-43.79%) ⬇️
pkg/utils/jwt.go 0.00% <0.00%> (-35.00%) ⬇️
pkg/controller/utils/capability.go 39.46% <0.00%> (-31.50%) ⬇️
...ponentdefinition/componentdefinition_controller.go 54.32% <0.00%> (-29.63%) ⬇️
... and 96 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wonderflow wonderflow added the backport release-1.7 add this label will automatically backport this PR to release-1.7 branch label Jan 12, 2023
@github-actions
Copy link

Successfully created backport PR #5323 for release-1.7.

barnettZQG pushed a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
Signed-off-by: hnd4r7 <307365651@qq.com>

Signed-off-by: hnd4r7 <307365651@qq.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
Signed-off-by: hnd4r7 <307365651@qq.com>

Signed-off-by: hnd4r7 <307365651@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.7 add this label will automatically backport this PR to release-1.7 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants