Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: failed to create the record when rollbacking the application #5377

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

barnettZQG
Copy link
Collaborator

Signed-off-by: barnettZQG barnett.zqg@gmail.com

Description of your changes

image

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

/cc @wonderflow

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@barnettZQG barnettZQG added the backport release-1.7 add this label will automatically backport this PR to release-1.7 branch label Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 61.20% // Head: 61.15% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (57d85ec) compared to base (f733d74).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5377      +/-   ##
==========================================
- Coverage   61.20%   61.15%   -0.06%     
==========================================
  Files         308      308              
  Lines       46778    46781       +3     
==========================================
- Hits        28631    28608      -23     
- Misses      15189    15203      +14     
- Partials     2958     2970      +12     
Flag Coverage Δ
apiserver-e2etests 32.27% <0.00%> (-0.06%) ⬇️
apiserver-unittests 36.20% <0.00%> (-0.01%) ⬇️
core-unittests 55.28% <ø> (+<0.01%) ⬆️
e2e-multicluster-test 18.97% <0.00%> (-0.03%) ⬇️
e2e-rollout-tests 21.08% <ø> (+0.06%) ⬆️
e2etests 26.45% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/service/application.go 58.17% <0.00%> (-0.31%) ⬇️
...es/policydefinition/policydefinition_controller.go 69.51% <0.00%> (-10.98%) ⬇️
pkg/resourcekeeper/resourcekeeper.go 61.81% <0.00%> (-5.46%) ⬇️
...dev/v1alpha2/application/application_controller.go 83.25% <0.00%> (-3.03%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 87.02% <0.00%> (-1.90%) ⬇️
pkg/velaql/providers/query/collector.go 68.80% <0.00%> (-1.84%) ⬇️
pkg/addon/push.go 75.14% <0.00%> (-1.13%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 63.78% <0.00%> (-1.09%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 70.83% <0.00%> (-0.91%) ⬇️
.../core/scopes/healthscope/healthscope_controller.go 72.14% <0.00%> (-0.66%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Successfully created backport PR #5381 for release-1.7.

zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.7 add this label will automatically backport this PR to release-1.7 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants