Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: need podAntiAffinity for vela pods, in order to make kubevela h… #5465

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

StevenLeiZhang
Copy link
Collaborator

@StevenLeiZhang StevenLeiZhang commented Feb 9, 2023

…igh availability

Signed-off-by: StevenLeiZhang zhangleiic@163.com

Description of your changes

Fixes #5425

  1. add default podAntiAffinity for vela-core and vela-cluster-gateway
  2. if user customize affinity in helm's values file, use user's content. if not, use default affinity.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

…igh availability

Signed-off-by: StevenLeiZhang <zhangleiic@163.com>
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 61.22% // Head: 61.21% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (037d973) compared to base (c2de316).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5465      +/-   ##
==========================================
- Coverage   61.22%   61.21%   -0.01%     
==========================================
  Files         310      310              
  Lines       47160    47160              
==========================================
- Hits        28875    28871       -4     
  Misses      15291    15291              
- Partials     2994     2998       +4     
Flag Coverage Δ
apiserver-e2etests 35.68% <ø> (+0.11%) ⬆️
apiserver-unittests 36.25% <ø> (ø)
core-unittests 55.27% <ø> (+0.01%) ⬆️
e2e-multicluster-test 19.06% <ø> (-0.03%) ⬇️
e2e-rollout-tests 20.74% <ø> (+0.02%) ⬆️
e2etests 25.72% <ø> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../core/scopes/healthscope/healthscope_controller.go 57.89% <0.00%> (-14.92%) ⬇️
...dev/v1alpha2/application/application_controller.go 83.25% <0.00%> (-3.03%) ⬇️
pkg/controller/utils/capability.go 80.07% <0.00%> (-1.71%) ⬇️
pkg/addon/push.go 75.14% <0.00%> (-1.13%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 70.87% <0.00%> (-0.91%) ⬇️
pkg/apiserver/domain/service/application.go 58.43% <0.00%> (+0.18%) ⬆️
pkg/addon/addon.go 63.62% <0.00%> (+0.28%) ⬆️
...ler/core.oam.dev/v1alpha2/application/generator.go 88.14% <0.00%> (+0.80%) ⬆️
...server/infrastructure/datastore/kubeapi/kubeapi.go 64.86% <0.00%> (+1.08%) ⬆️
pkg/cue/definition/template.go 68.24% <0.00%> (+1.48%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wonderflow wonderflow merged commit 98e04eb into kubevela:master Feb 10, 2023
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
…igh availability (kubevela#5465)

Signed-off-by: StevenLeiZhang <zhangleiic@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] need podAntiAffinity for vela pods, in order to make kubevela high availability
3 participants