Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use correct helm value when setting apprev compression #5477

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

charlie0129
Copy link
Member

Signed-off-by: Charlie Chiang charlie_c_0129@outlook.com

Description of your changes

Previously, turning RT compression on will enable both RT compression and AppRev compression, due to the usage of a wrong Helm Value. This pr fixes this.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
@charlie0129 charlie0129 added the backport release-1.7 add this label will automatically backport this PR to release-1.7 branch label Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 61.39% // Head: 61.36% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (17c3620) compared to base (98e04eb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5477      +/-   ##
==========================================
- Coverage   61.39%   61.36%   -0.04%     
==========================================
  Files         310      310              
  Lines       47159    47159              
==========================================
- Hits        28955    28939      -16     
- Misses      15213    15225      +12     
- Partials     2991     2995       +4     
Flag Coverage Δ
apiserver-e2etests 35.59% <ø> (-0.06%) ⬇️
apiserver-unittests 36.28% <ø> (+0.05%) ⬆️
core-unittests 55.31% <ø> (-0.12%) ⬇️
e2e-multicluster-test 19.08% <ø> (-0.03%) ⬇️
e2e-rollout-tests 20.69% <ø> (-0.02%) ⬇️
e2etests 26.14% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/policydefinition/policydefinition_controller.go 69.51% <0.00%> (-10.98%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 69.41% <0.00%> (-7.06%) ⬇️
pkg/apiserver/interfaces/api/oam_application.go 59.18% <0.00%> (-5.11%) ⬇️
pkg/resourcekeeper/dispatch.go 75.00% <0.00%> (-3.13%) ⬇️
pkg/apiserver/utils/bcode/bcode.go 51.11% <0.00%> (-2.23%) ⬇️
...er/core.oam.dev/v1alpha2/application/dispatcher.go 77.87% <0.00%> (-1.77%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 87.02% <0.00%> (-0.95%) ⬇️
pkg/controller/utils/capability.go 81.21% <0.00%> (-0.57%) ⬇️
pkg/addon/addon.go 63.33% <0.00%> (-0.29%) ⬇️
pkg/apiserver/domain/service/application.go 58.43% <0.00%> (-0.19%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@github-actions
Copy link

Successfully created backport PR #5478 for release-1.7.

zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
…#5477)

Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.7 add this label will automatically backport this PR to release-1.7 branch type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants