Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add codeowner #5496

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Feb 14, 2023

Signed-off-by: Qiaozp qiaozhongpei.qzp@alibaba-inc.com

Description of your changes

Add myself @chivalryq as codeowner.

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Copy link
Collaborator

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 61.29% // Head: 61.28% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (dba1cca) compared to base (ff05180).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5496      +/-   ##
==========================================
- Coverage   61.29%   61.28%   -0.02%     
==========================================
  Files         310      310              
  Lines       47159    47158       -1     
==========================================
- Hits        28908    28900       -8     
- Misses      15256    15259       +3     
- Partials     2995     2999       +4     
Flag Coverage Δ
apiserver-e2etests 35.68% <ø> (+0.14%) ⬆️
apiserver-unittests 36.22% <ø> (-0.03%) ⬇️
core-unittests 55.37% <ø> (+0.04%) ⬆️
e2e-multicluster-test 19.01% <ø> (-0.08%) ⬇️
e2e-rollout-tests 20.95% <ø> (+0.28%) ⬆️
e2etests 26.52% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/policydefinition/policydefinition_controller.go 69.51% <0.00%> (-14.64%) ⬇️
...tepdefinition/workflowstepdefinition_controller.go 70.58% <0.00%> (-7.06%) ⬇️
pkg/apiserver/event/sync/worker.go 67.69% <0.00%> (-4.62%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 43.82% <0.00%> (-4.50%) ⬇️
pkg/oam/util/helper.go 61.91% <0.00%> (-2.09%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 86.07% <0.00%> (-1.90%) ⬇️
pkg/cue/definition/template.go 66.76% <0.00%> (-1.49%) ⬇️
pkg/apiserver/domain/service/authentication.go 48.57% <0.00%> (-1.30%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 62.97% <0.00%> (-1.09%) ⬇️
...ler/core.oam.dev/v1alpha2/application/generator.go 87.33% <0.00%> (-0.81%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@wonderflow wonderflow merged commit 48db981 into kubevela:master Feb 14, 2023
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
* Chore: add codeowner

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>

* finer-grained permission

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>

* backup

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>

---------

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants