Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support resume a specific suspend step in workflow #5505

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Feb 14, 2023

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

Support resume a specific suspend step in workflow like:

vela workflow resume --step=step1

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 59.49% // Head: 61.34% // Increases project coverage by +1.85% 🎉

Coverage data is based on head (af0bc3e) compared to base (a1840d5).
Patch coverage: 38.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5505      +/-   ##
==========================================
+ Coverage   59.49%   61.34%   +1.85%     
==========================================
  Files         305      310       +5     
  Lines       47099    47274     +175     
==========================================
+ Hits        28023    29002     +979     
+ Misses      16140    15270     -870     
- Partials     2936     3002      +66     
Flag Coverage Δ
apiserver-e2etests 35.49% <6.34%> (-0.28%) ⬇️
apiserver-unittests 36.31% <6.66%> (+0.16%) ⬆️
core-unittests 55.18% <35.13%> (-0.08%) ⬇️
e2e-multicluster-test 19.07% <10.25%> (?)
e2e-rollout-tests 20.99% <ø> (-0.03%) ⬇️
e2etests 26.53% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/interfaces/api/workflow.go 18.04% <0.00%> (ø)
pkg/apiserver/domain/service/pipeline.go 70.32% <33.33%> (+4.82%) ⬆️
pkg/apiserver/domain/service/workflow.go 52.30% <33.33%> (+0.50%) ⬆️
pkg/workflow/operation/operation.go 40.05% <36.03%> (-1.24%) ⬇️
pkg/apiserver/interfaces/api/pipeline.go 54.47% <85.71%> (+0.41%) ⬆️
pkg/apiserver/interfaces/api/application.go 59.95% <100.00%> (+0.03%) ⬆️
pkg/apiserver/interfaces/api/oam_application.go 59.18% <0.00%> (-5.11%) ⬇️
pkg/apiserver/event/sync/worker.go 72.30% <0.00%> (-4.62%) ⬇️
pkg/config/provider/provider.go 68.35% <0.00%> (-3.80%) ⬇️
pkg/apiserver/utils/bcode/bcode.go 51.11% <0.00%> (-2.23%) ⬇️
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FogDong FogDong force-pushed the fix-operation branch 3 times, most recently from 1279017 to 16a99ee Compare February 16, 2023 03:49
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@StevenLeiZhang StevenLeiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderflow wonderflow merged commit 3a8746e into kubevela:master Feb 18, 2023
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants