Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: correct the doc of recycle application env api #5537

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

zhanghw0354
Copy link
Contributor

@zhanghw0354 zhanghw0354 commented Feb 20, 2023

Description of your changes

The doc of recycle application env api is wrong, just correct it.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@zhanghw0354 zhanghw0354 changed the title correct the doc of recycle application env api Docs: correct the doc of recycle application env api Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 46.31% // Head: 61.57% // Increases project coverage by +15.26% 🎉

Coverage data is based on head (5dca4d2) compared to base (8ff77c4).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 5dca4d2 differs from pull request most recent head baca5e2. Consider uploading reports for the commit baca5e2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5537       +/-   ##
===========================================
+ Coverage   46.31%   61.57%   +15.26%     
===========================================
  Files         308      311        +3     
  Lines       47784    47919      +135     
===========================================
+ Hits        22130    29505     +7375     
+ Misses      22869    15367     -7502     
- Partials     2785     3047      +262     
Flag Coverage Δ
apiserver-e2etests 35.67% <100.00%> (+0.02%) ⬆️
apiserver-unittests 36.26% <0.00%> (ø)
core-unittests 55.64% <ø> (?)
e2e-multicluster-test 18.72% <ø> (+0.04%) ⬆️
e2e-rollout-tests 21.11% <ø> (+0.09%) ⬆️
e2etests 26.60% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/interfaces/api/application.go 59.95% <100.00%> (ø)
pkg/multicluster/cluster_management.go 37.23% <0.00%> (-2.66%) ⬇️
pkg/apiserver/domain/service/workflow.go 51.95% <0.00%> (-2.25%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 47.19% <0.00%> (-1.13%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 62.97% <0.00%> (-1.09%) ⬇️
pkg/apiserver/event/sync/worker.go 72.30% <0.00%> (ø)
cmd/core/main.go 0.00% <0.00%> (ø)
pkg/workflow/providers/time/date.go 100.00% <0.00%> (ø)
pkg/webhook/common/rollout/rollout_plan.go 37.63% <0.00%> (ø)
pkg/apiserver/domain/service/application.go 58.62% <0.00%> (+0.18%) ⬆️
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wonderflow
Copy link
Collaborator

please sign the DCO

@wonderflow wonderflow added the backport release-1.7 add this label will automatically backport this PR to release-1.7 branch label Feb 20, 2023
zhanghw0354 and others added 2 commits February 21, 2023 18:07
Signed-off-by: zhanghw0354 <zhanghaiwen_yewu@cmss.chinamobile.com>
Signed-off-by: zhanghw0354 <zhanghaiwen_yewu@cmss.chinamobile.com>
@zhanghw0354
Copy link
Contributor Author

please sign the DCO

@wonderflow ,Just signed the DCO, Thanks.

@FogDong FogDong merged commit 4ad0c7a into kubevela:master Feb 27, 2023
@github-actions
Copy link

Backport failed for release-1.7, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-1.7
git worktree add -d .worktree/backport-5537-to-release-1.7 origin/release-1.7
cd .worktree/backport-5537-to-release-1.7
git checkout -b backport-5537-to-release-1.7
ancref=$(git merge-base 8ff77c4486cafb656a0ec683df44eea5a2848761 baca5e26e20114a2bf1cfecac609b8c505f09c63)
git cherry-pick -x $ancref..baca5e26e20114a2bf1cfecac609b8c505f09c63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.7 add this label will automatically backport this PR to release-1.7 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants